clean tslint comments

package.json

@@ -133,7 +133,6 @@
     "fluent-ffmpeg": "^2.1.0",
     "gl-matrix": "^3.0.0",
     "glob": "^7.1.0",
-    "is-pr": "^1.0.0",
     "jsdoc-to-markdown": "^5.0.0",
     "markdownlint-cli": "^0.19.0",
     "nyc": "^14.0.0",

src/accessory.spec.ts

@@ -17,10 +17,8 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
-// tslint:disable:max-classes-per-file
 
-import test  from 'blue-tape'
+ import test  from 'blue-tape'
 // import sinon from 'sinon'
 
 import {
@@ -58,9 +56,7 @@ test('Two clone-ed classes have different static puppet value', async t => {
 
   class FixtureClass extends Accessory {}
 
-  // tslint:disable-next-line:variable-name
   const ClonedClass1 = cloneClass(FixtureClass)
-  // tslint:disable-next-line:variable-name
   const ClonedClass2 = cloneClass(FixtureClass)
 
   ClonedClass1.puppet = EXPECTED_PUPPET1

src/config.spec.ts

@@ -17,7 +17,7 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
+
 import test  from 'blue-tape'
 
 import { config } from './config'

src/config.ts

@@ -16,7 +16,6 @@
  *   limitations under the License.
  *
  */
-// tslint:disable-next-line:no-reference
 /// <reference path="./typings.d.ts" />
 
 import os    from 'os'

src/helper-functions/impure/get-port.spec.ts

@@ -17,7 +17,7 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
+
 import test  from 'blue-tape'
 
 import net from 'net'

src/helper-functions/pure/try-wait.spec.ts

@@ -17,7 +17,6 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
 import test  from 'blue-tape'
 import sinon from 'sinon'
 

src/helper-functions/pure/xml.spec.ts

@@ -17,8 +17,7 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
-import test  from 'blue-tape'
+import { test } from 'tstest'
 
 import {
   digestEmoji,

src/io.spec.ts

 #!/usr/bin/env ts-node
 
-// tslint:disable:no-shadowed-variable
 import test  from 'blue-tape'
 
 import { Io }       from './io'

src/puppet-manager.spec.ts

@@ -18,7 +18,6 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
 import test  from 'blue-tape'
 
 import {

src/user/contact.accessory.spec.ts

@@ -13,11 +13,9 @@ import {
   Contact as GlobalContact,
 }                           from './contact'
 
-// tslint:disable-next-line:variable-name
 const Contact = cloneClass(GlobalContact)
 
 test('Should not be able to instanciate directly', async t => {
-  // tslint:disable-next-line:variable-name
   const MyContact = cloneClass(Contact)
   t.throws(() => {
     const c = MyContact.load('xxx')
@@ -31,7 +29,6 @@ test('Should not be able to instanciate directly', async t => {
 })
 
 test('Should not be able to instanciate through cloneClass without puppet', async t => {
-  // tslint:disable-next-line:variable-name
   const MyContact = cloneClass(Contact)
 
   t.throws(() => {
@@ -47,7 +44,6 @@ test('Should not be able to instanciate through cloneClass without puppet', asyn
 })
 
 test('should be able to instanciate through cloneClass with puppet', async t => {
-  // tslint:disable-next-line:variable-name
   const MyContact = cloneClass(Contact)
 
   MyContact.puppet = new PuppetMock()

src/user/contact.spec.ts

@@ -17,9 +17,6 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
-// tslint:disable:max-classes-per-file
-
 import test  from 'blue-tape'
 import sinon from 'sinon'
 

src/user/contact.ts

@@ -55,9 +55,7 @@ export const POOL = Symbol('pool')
  */
 export class Contact extends Accessory implements Sayable {
 
-  // tslint:disable-next-line:variable-name
   public static Type   = ContactType
-  // tslint:disable-next-line:variable-name
   public static Gender = ContactGender
 
   protected static [POOL]: Map<string, Contact>
@@ -290,7 +288,6 @@ export class Contact extends Accessory implements Sayable {
     super()
     log.silly('Contact', `constructor(${id})`)
 
-    // tslint:disable-next-line:variable-name
     const MyClass = instanceToClass(this, Contact)
 
     if (MyClass === Contact) {

src/user/friendship.ts

@@ -57,7 +57,6 @@ import {
  */
 export class Friendship extends Accessory implements Acceptable {
 
-  // tslint:disable-next-line:variable-name
   public static Type = FriendshipType
 
   /**
@@ -169,7 +168,6 @@ export class Friendship extends Accessory implements Acceptable {
     super()
     log.verbose('Friendship', 'constructor(id=%s)', id)
 
-    // tslint:disable-next-line:variable-name
     const MyClass = instanceToClass(this, Friendship)
 
     if (MyClass === Friendship) {

src/user/message.spec.ts

@@ -18,9 +18,6 @@
  *
  */
 
-// tslint:disable:no-shadowed-variable
-// tslint:disable:max-classes-per-file
-
 import test  from 'blue-tape'
 import sinon from 'sinon'
 

src/user/message.ts

@@ -81,7 +81,6 @@ export class Message extends Accessory implements Sayable {
   /**
    * @ignore
    */
-  // tslint:disable-next-line:variable-name
   public static readonly Type = MessageType
 
   /**
@@ -207,7 +206,6 @@ export class Message extends Accessory implements Sayable {
       this.constructor.name,
     )
 
-    // tslint:disable-next-line:variable-name
     const MyClass = instanceToClass(this, Message)
 
     if (MyClass === Message) {

src/user/room-invitation.ts

@@ -64,7 +64,6 @@ export class RoomInvitation extends Accessory implements Acceptable {
     super()
     log.verbose('RoomInvitation', 'constructor(id=%s)', id)
 
-    // tslint:disable-next-line:variable-name
     const MyClass = instanceToClass(this, RoomInvitation)
 
     if (MyClass === RoomInvitation) {

src/user/room.spec.ts

@@ -17,9 +17,6 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
-// tslint:disable:max-classes-per-file
-
 import test  from 'blue-tape'
 import sinon from 'sinon'
 

src/user/room.ts

@@ -281,7 +281,6 @@ export class Room extends Accessory implements Sayable {
     super()
     log.silly('Room', `constructor(${id})`)
 
-    // tslint:disable-next-line:variable-name
     const MyClass = instanceToClass(this, Room)
 
     if (MyClass === Room) {

src/version.spec.ts

 #!/usr/bin/env ts-node
 
-// tslint:disable:no-shadowed-variable
 import test  from 'blue-tape'
 
 import {

src/wechaty.spec.ts

@@ -18,7 +18,6 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
 import test  from 'blue-tape'
 import sinon from 'sinon'
 

tests/electron.spec.ts

@@ -18,7 +18,6 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
 import test  from 'blue-tape'
 
 test('Electron smoke testing', async t => {

tests/fixtures/smoke-testing.ts

 #!/usr/bin/env ts-node
 
-// tslint:disable:no-var-requires
-const isPR = require('is-pr')
-
 import {
   Wechaty,
   VERSION,
@@ -15,11 +12,17 @@ function getBotList (): Wechaty[] {
     // new Wechaty({ puppet: 'wechaty-puppet-puppeteer' }),
   ]
 
-  if (!isPR) {
+  if (process.env.WECHATY_PUPPET_HOSTIE_TOKEN) {
+    botList.push(
+      new Wechaty({
+        puppet: 'wechaty-puppet-padplus',
+      })
+    )
+  }
+  if (process.env.WECHATY_PUPPET_PADPLUS_TOKEN) {
     botList.push(
       new Wechaty({
         puppet: 'wechaty-puppet-padplus',
-        // we use WECHATY_PUPPET_PADPLUS_TOKEN environment variable at here.
       })
     )
   }
@@ -38,7 +41,7 @@ async function main () {
       botList.map(bot => bot.start()),
     )
     botList.forEach(
-      bot => console.log(`Wechaty v${bot.version()} smoking test passed.`),
+      bot => console.info(`Wechaty v${bot.version()} smoking test passed.`),
     )
   } catch (e) {
     console.error(e)

tests/node.spec.ts

@@ -18,7 +18,6 @@
  *   limitations under the License.
  *
  */
-// tslint:disable:no-shadowed-variable
 import test  from 'blue-tape'
 
 // import { log }  from '../src/config'