From e059fb5ba750015820aa1a5d944ed37593041e61 Mon Sep 17 00:00:00 2001
From: Daniel Lockyer <thisisdaniellockyer@gmail.com>
Date: Fri, 31 Mar 2017 17:09:32 +0100
Subject: [PATCH] Remove unnecessary reference

---
 src/fs/dir.rs         | 4 ++--
 src/fs/file.rs        | 2 +-
 src/options/mod.rs    | 6 +++---
 src/output/details.rs | 6 +++---
 src/output/grid.rs    | 2 +-
 src/output/mod.rs     | 6 +++---
 6 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/fs/dir.rs b/src/fs/dir.rs
index 3234736..cb117f1 100644
--- a/src/fs/dir.rs
+++ b/src/fs/dir.rs
@@ -48,13 +48,13 @@ impl Dir {
     pub fn files<'dir>(&'dir self) -> Files<'dir> {
         Files {
             inner: self.contents.iter(),
-            dir: &self,
+            dir: self,
         }
     }
 
     /// Whether this directory contains a file with the given path.
     pub fn contains(&self, path: &Path) -> bool {
-        self.contents.iter().any(|ref p| p.as_path() == path)
+        self.contents.iter().any(|p| p.as_path() == path)
     }
 
     /// Append a path onto the path specified by this directory.
diff --git a/src/fs/file.rs b/src/fs/file.rs
index c74055f..1986059 100644
--- a/src/fs/file.rs
+++ b/src/fs/file.rs
@@ -403,7 +403,7 @@ impl<'dir> File<'dir> {
 
 impl<'a> AsRef<File<'a>> for File<'a> {
     fn as_ref(&self) -> &File<'a> {
-        &self
+        self
     }
 }
 
diff --git a/src/options/mod.rs b/src/options/mod.rs
index b666503..853973f 100644
--- a/src/options/mod.rs
+++ b/src/options/mod.rs
@@ -138,9 +138,9 @@ impl Options {
     /// Determines the complete set of options based on the given command-line
     /// arguments, after they’ve been parsed.
     fn deduce(matches: &getopts::Matches) -> Result<Options, Misfire> {
-        let dir_action = DirAction::deduce(&matches)?;
-        let filter = FileFilter::deduce(&matches)?;
-        let view = View::deduce(&matches, filter.clone(), dir_action)?;
+        let dir_action = DirAction::deduce(matches)?;
+        let filter = FileFilter::deduce(matches)?;
+        let view = View::deduce(matches, filter.clone(), dir_action)?;
 
         Ok(Options {
             dir_action: dir_action,
diff --git a/src/output/details.rs b/src/output/details.rs
index 6afb678..6e524c8 100644
--- a/src/output/details.rs
+++ b/src/output/details.rs
@@ -207,7 +207,7 @@ impl Details {
         // Build the table to put rows in.
         let mut table = Table {
             columns: &*columns_for_dir,
-            opts: &self,
+            opts: self,
             env: env,
             rows: Vec::new(),
         };
@@ -306,7 +306,7 @@ impl Details {
             let mut width = DisplayWidth::from(&*egg.file.name);
 
             if egg.file.dir.is_none() {
-                if let Some(ref parent) = egg.file.path.parent() {
+                if let Some(parent) = egg.file.path.parent() {
                     width = width + 1 + DisplayWidth::from(parent.to_string_lossy().as_ref());
                 }
             }
@@ -456,7 +456,7 @@ impl<'a, U: Users+Groups+'a> Table<'a, U> {
         let mut width = DisplayWidth::from(&*file.name);
 
         if file.dir.is_none() {
-            if let Some(ref parent) = file.path.parent() {
+            if let Some(parent) = file.path.parent() {
                 width = width + 1 + DisplayWidth::from(parent.to_string_lossy().as_ref());
             }
         }
diff --git a/src/output/grid.rs b/src/output/grid.rs
index b5342a1..e03b12e 100644
--- a/src/output/grid.rs
+++ b/src/output/grid.rs
@@ -31,7 +31,7 @@ impl Grid {
             let mut width = DisplayWidth::from(&*file.name);
 
             if file.dir.is_none() {
-                if let Some(ref parent) = file.path.parent() {
+                if let Some(parent) = file.path.parent() {
                     width = width + 1 + DisplayWidth::from(parent.to_string_lossy().as_ref());
                 }
             }
diff --git a/src/output/mod.rs b/src/output/mod.rs
index c39c88e..242ecb1 100644
--- a/src/output/mod.rs
+++ b/src/output/mod.rs
@@ -23,7 +23,7 @@ pub fn filename(file: &File, colours: &Colours, links: bool) -> TextCellContents
     let mut bits = Vec::new();
 
     if file.dir.is_none() {
-        if let Some(ref parent) = file.path.parent() {
+        if let Some(parent) = file.path.parent() {
             let coconut = parent.components().count();
 
             if coconut == 1 && parent.has_root() {
@@ -37,7 +37,7 @@ pub fn filename(file: &File, colours: &Colours, links: bool) -> TextCellContents
     }
 
     if !file.name.is_empty() {
-        bits.push(file_colour(colours, &file).paint(file.name.clone()));
+        bits.push(file_colour(colours, file).paint(file.name.clone()));
     }
 
     if links && file.is_link() {
@@ -47,7 +47,7 @@ pub fn filename(file: &File, colours: &Colours, links: bool) -> TextCellContents
                 bits.push(colours.punctuation.paint("->"));
                 bits.push(Style::default().paint(" "));
 
-                if let Some(ref parent) = target.path.parent() {
+                if let Some(parent) = target.path.parent() {
                     let coconut = parent.components().count();
 
                     if coconut == 1 && parent.has_root() {
-- 
GitLab