diff --git a/src/exa.rs b/src/exa.rs index 8f0147b135e432a6a5a133f49ffa9500d8593066..8f6b2c13bb51263c792d2921fa22b51e404936ff 100644 --- a/src/exa.rs +++ b/src/exa.rs @@ -69,7 +69,7 @@ impl<'w, W: Write + 'w> Exa<'w, W> { self.args.push(".".to_owned()); } - for file_name in self.args.iter() { + for file_name in &self.args { match File::from_path(Path::new(&file_name), None) { Err(e) => { writeln!(stderr(), "{}: {}", file_name, e)?; diff --git a/src/output/details.rs b/src/output/details.rs index ac92510218a994a21fe7051e7a96b01a88f66b5d..6afb6782ac1f07f830650c12cdf5f2247e5eedaa 100644 --- a/src/output/details.rs +++ b/src/output/details.rs @@ -481,7 +481,7 @@ impl<'a, U: Users+Groups+'a> Table<'a, U> { /// Use the list of columns to find which cells should be produced for /// this file, per-column. pub fn cells_for_file(&self, file: &File, xattrs: bool) -> Vec { - self.columns.clone().iter() + self.columns.iter() .map(|c| self.display(file, c, xattrs)) .collect() } diff --git a/src/output/grid_details.rs b/src/output/grid_details.rs index 4600d4332c4708096d7249ee0728902d8ab1fd7e..1ad38bc0f64acd3ef65825b9b3146fd48768ad1e 100644 --- a/src/output/grid_details.rs +++ b/src/output/grid_details.rs @@ -122,7 +122,7 @@ impl GridDetails { if self.grid.across { for row in 0 .. height { - for column in columns.iter() { + for column in &columns { if row < column.len() { let cell = grid::Cell { contents: ANSIStrings(&column[row].contents).to_string(), @@ -135,7 +135,7 @@ impl GridDetails { } } else { - for column in columns.iter() { + for column in &columns { for cell in column.iter() { let cell = grid::Cell { contents: ANSIStrings(&cell.contents).to_string(),