Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
2dot5
ClickHouse
提交
40a99b74
C
ClickHouse
项目概览
2dot5
/
ClickHouse
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
C
ClickHouse
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
40a99b74
编写于
3月 26, 2021
作者:
A
alexey-milovidov
提交者:
GitHub
3月 26, 2021
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #21492 from azat/client-fix-highlight-multiline-comment
Fix heap-buffer-overflow in highlighting multi-line comments
上级
0e420605
f1efa335
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
30 addition
and
2 deletion
+30
-2
src/Parsers/Lexer.cpp
src/Parsers/Lexer.cpp
+2
-1
tests/queries/0_stateless/01755_client_highlight_multi_line_comment_regression.expect
...755_client_highlight_multi_line_comment_regression.expect
+25
-0
tests/queries/0_stateless/01755_client_highlight_multi_line_comment_regression.reference
..._client_highlight_multi_line_comment_regression.reference
+0
-0
tests/queries/0_stateless/arcadia_skip_list.txt
tests/queries/0_stateless/arcadia_skip_list.txt
+1
-0
tests/queries/skip_list.json
tests/queries/skip_list.json
+2
-1
未找到文件。
src/Parsers/Lexer.cpp
浏览文件 @
40a99b74
...
...
@@ -275,7 +275,8 @@ Token Lexer::nextTokenImpl()
else
++
pos
;
}
return
Token
(
TokenType
::
ErrorMultilineCommentIsNotClosed
,
token_begin
,
end
);
pos
=
end
;
return
Token
(
TokenType
::
ErrorMultilineCommentIsNotClosed
,
token_begin
,
pos
);
}
}
return
Token
(
TokenType
::
Slash
,
token_begin
,
pos
);
...
...
tests/queries/0_stateless/01755_client_highlight_multi_line_comment_regression.expect
0 → 100755
浏览文件 @
40a99b74
#!/usr/bin/expect -f
log_user 0
set timeout 5
match_max 100000
# A default timeout action is to do nothing, change it to fail
expect_after {
timeout {
exit 2
}
}
set basedir [file dirname $argv0]
spawn bash -c "source $basedir/../shell_config.sh ; \$CLICKHOUSE_CLIENT_BINARY \$CLICKHOUSE_CLIENT_OPT"
expect ":) "
# regression for heap-buffer-overflow issue (under ASAN)
send -- "/**"
expect "/**"
# just in case few more bytes
send -- "foobar"
expect "/**foobar"
send -- "\3\4"
expect eof
tests/queries/0_stateless/01755_client_highlight_multi_line_comment_regression.reference
0 → 100644
浏览文件 @
40a99b74
tests/queries/0_stateless/arcadia_skip_list.txt
浏览文件 @
40a99b74
...
...
@@ -212,6 +212,7 @@
01017_uniqCombined_memory_usage
01747_join_view_filter_dictionary
01748_dictionary_table_dot
01755_client_highlight_multi_line_comment_regression
00950_dict_get
01683_flat_dictionary
01681_cache_dictionary_simple_key
...
...
tests/queries/skip_list.json
浏览文件 @
40a99b74
...
...
@@ -95,7 +95,8 @@
"01370_client_autocomplete_word_break_characters"
,
"01676_clickhouse_client_autocomplete"
,
"01193_metadata_loading"
,
"01455_time_zones"
"01455_time_zones"
,
"01755_client_highlight_multi_line_comment_regression"
],
"release-build"
:
[
],
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录