Update dependencies and remove tslint leftovers (#5636)

* Update dependencies and remove tslib leftovers

* Revert go package changes

* Update lint-staged config

* Update eslint config

* Remove redundant file

* Update dev docs

angular.json

@@ -148,15 +148,6 @@
               "src/app/frontend/assets"
             ]
           }
-        },
-        "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
-          "options": {
-            "tsConfig": [
-              "src/tsconfig.json"
-            ],
-            "exclude": []
-          }
         }
       }
     }

cypress/support/commands.ts

@@ -30,9 +30,7 @@ Cypress.Commands.add('foo', () => 'foo');
 // // see more example of adding custom commands to Cypress TS interface
 // // in https://github.com/cypress-io/add-cypress-custom-command-in-typescript
 // // add new command to the existing Cypress interface
-// // tslint:disable-next-line no-namespace
 declare namespace Cypress {
-  // tslint:disable-next-line interface-name
   interface Chainable {
     foo: () => string;
   }

docs/developer/code-conventions.md

@@ -38,7 +38,7 @@ We use following tools and settings for each check and formatting:
 | code    | tools                                                                    | setting |
 |---------|--------------------------------------------------------------------------|---------|
 | go      | [golangci-lint](https://github.com/golangci/golangci-lint)               | [`.golangci.yml`](../../.golangci.yml) |
-| ts      | [gts](https://github.com/google/gts)                                     | [`tslint.json`](../../tslint.json) |
+| ts      | [gts](https://github.com/google/gts)                                     | `eslintConfig` in [`package.json`](../../package.json) and [`.prettierrc.js`](../../.prettierrc.js) |
 | scss    | [sass-lint](https://github.com/sasstools/sass-lint)                      | [`.sass-lint.yml`](../../.sass-lint.yml) |
 | scss    | [scssfmt](https://github.com/morishitter/scssfmt)                        | - |
 | html    | [js-beautify](https://github.com/beautify-web/js-beautify)               | options in [`format.sh`](../../aio/scripts/format.sh) |

package.json

@@ -39,7 +39,7 @@
     "check:backend": "golangci-lint run -c .golangci.yml ./src/app/backend/...",
     "check:codegen": "aio/scripts/verify-codegen.sh",
     "check:frontend": "concurrently \"npm run check:frontend:ts\" \"npm run check:frontend:scss\" \"npm run check:frontend:html\"",
-    "check:frontend:ts": "gts check",
+    "check:frontend:ts": "gts lint",
     "check:frontend:scss": "./aio/scripts/format.sh --styles --check && ./node_modules/sass-lint/bin/sass-lint.js -c .sass-lint.yml 'src/app/frontend/**/*.scss' -v -q",
     "check:frontend:html": "./aio/scripts/format.sh --html --check",
     "check:license": "license-check-and-add check",
@@ -63,20 +63,16 @@
   },
   "lint-staged": {
     "src/**/*.ts": [
-      "gts fix",
-      "git add"
+      "gts fix"
     ],
     "src/**/*.scss": [
-      "scssfmt",
-      "git add"
+      "scssfmt"
     ],
     "src/**/*.go": [
-      "./aio/scripts/pre-commit-golangci-lint.sh",
-      "git add"
+      "./aio/scripts/pre-commit-golangci-lint.sh"
     ],
     "src/**/*.html": [
-      "./aio/scripts/pre-commit-i18n.sh",
-      "git add"
+      "./aio/scripts/pre-commit-i18n.sh"
     ]
   },
   "xliffmergeOptions": {
@@ -95,21 +91,21 @@
     "beautifyOutput": true
   },
   "dependencies": {
-    "@angular/animations": "10.1.1",
-    "@angular/cdk": "10.2.0",
-    "@angular/common": "10.1.1",
-    "@angular/compiler": "10.1.1",
-    "@angular/core": "10.1.1",
+    "@angular/animations": "10.1.6",
+    "@angular/cdk": "10.2.5",
+    "@angular/common": "10.1.6",
+    "@angular/compiler": "10.1.6",
+    "@angular/core": "10.1.6",
     "@angular/flex-layout": "10.0.0-beta.32",
-    "@angular/forms": "10.1.1",
-    "@angular/localize": "10.1.1",
-    "@angular/material": "10.2.0",
-    "@angular/platform-browser": "10.1.1",
-    "@angular/platform-browser-dynamic": "10.1.1",
-    "@angular/router": "10.1.1",
+    "@angular/forms": "10.1.6",
+    "@angular/localize": "10.1.6",
+    "@angular/material": "10.2.5",
+    "@angular/platform-browser": "10.1.6",
+    "@angular/platform-browser-dynamic": "10.1.6",
+    "@angular/router": "10.1.6",
     "@swimlane/ngx-charts": "16.0.0",
     "@types/c3": "0.7.4",
-    "@types/d3": "5.16.1",
+    "@types/d3": "5.16.3",
     "@types/d3-scale": "3.1.0",
     "@types/file-saver": "2.0.1",
     "@types/highlight.js": "9.12.4",
@@ -131,9 +127,9 @@
     "rxjs": "6.6.3",
     "rxjs-compat": "6.6.3",
     "sockjs-client": "1.5.0",
-    "systemjs": "6.6.1",
+    "systemjs": "6.7.1",
     "truncate-url": "1.0.0",
-    "tslib": "2.0.2",
+    "tslib": "2.0.3",
     "web-animations-js": "2.3.2",
     "xterm": "4.9.0",
     "xterm-addon-fit": "0.4.0",
@@ -141,26 +137,26 @@
   },
   "devDependencies": {
     "@angular-devkit/build-angular": "0.1001.7",
-    "@angular/cli": "10.1.4",
-    "@angular/compiler-cli": "10.1.1",
+    "@angular/cli": "10.1.7",
+    "@angular/compiler-cli": "10.1.6",
     "@angular/language-service": "10.1.6",
-    "@cypress/webpack-preprocessor": "5.4.6",
+    "@cypress/webpack-preprocessor": "5.4.7",
     "@types/jasmine": "3.5.14",
     "@types/jasminewd2": "2.0.8",
     "@types/js-yaml": "3.12.5",
-    "@types/lodash": "4.14.161",
-    "@types/node": "14.11.5",
+    "@types/lodash": "4.14.162",
+    "@types/node": "14.11.8",
     "babel-cli": "6.26.0",
     "babel-preset-env": "1.7.0",
     "babel-register": "6.26.0",
     "codelyzer": "6.0.1",
     "concurrently": "5.3.0",
-    "cypress": "5.3.0",
+    "cypress": "5.4.0",
     "del": "6.0.0",
-    "eslint": "7.10.0",
+    "eslint": "7.11.0",
     "eslint-plugin-rxjs": "0.0.3-beta.30",
     "git-describe": "4.0.4",
-    "gts": "2.0.2",
+    "gts": "3.0.1",
     "gulp": "4.0.2",
     "gulp-filter": "6.0.0",
     "husky": "4.3.0",
@@ -180,21 +176,20 @@
     "minimatch": "3.0.4",
     "minimist": "1.2.5",
     "ngx-i18nsupport": "0.17.1",
-    "node-gyp": "7.1.0",
+    "node-gyp": "7.1.1",
     "node-sass": "4.14.1",
     "q": "1.5.1",
-    "raw-loader": "4.0.1",
+    "raw-loader": "4.0.2",
     "run-node": "2.0.0",
     "sass-lint": "1.13.1",
-    "sass-loader": "10.0.2",
+    "sass-loader": "10.0.3",
     "scssfmt": "1.0.7",
     "semver": "7.3.2",
     "source-map-explorer": "2.5.0",
     "tar": "6.0.5",
     "through2": "4.0.2",
-    "ts-loader": "8.0.4",
+    "ts-loader": "8.0.5",
     "ts-node": "9.0.0",
-    "tslint": "6.1.3",
     "typescript": "4.0.3",
     "wait-on": "5.2.0",
     "webpack-dev-server": "3.11.0"
@@ -215,7 +210,7 @@
       "rxjs"
     ],
     "rules": {
-      "@typescript-eslint/ban-ts-ignore": "off",
+      "@typescript-eslint/ban-ts-comment": "off",
       "@typescript-eslint/interface-name-prefix": "off",
       "@typescript-eslint/no-namespace": "off",
       "@typescript-eslint/no-unused-vars": "off",

src/app/frontend/common/resources/resource.ts

@@ -12,9 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import {HttpClient, HttpParams} from '@angular/common/http';
-import {merge, timer} from 'rxjs';
-import {publishReplay, refCount, switchMapTo} from 'rxjs/operators';
+import {HttpClient} from '@angular/common/http';
 
 // @ts-ignore
 export abstract class ResourceBase<T> {

src/app/frontend/common/services/global/interceptor.ts

@@ -18,8 +18,6 @@ import {CookieService} from 'ngx-cookie-service';
 import {Observable} from 'rxjs';
 import {CONFIG} from '../../../index.config';
 
-/* tslint:disable */
-// We can disable tslint for this file as any is required here.
 @Injectable()
 export class AuthInterceptor implements HttpInterceptor {
   constructor(private readonly cookies_: CookieService) {}
@@ -39,4 +37,3 @@ export class AuthInterceptor implements HttpInterceptor {
     return next.handle(req);
   }
 }
-/* tslint:enable */

src/app/frontend/index.spec.ts

@@ -13,7 +13,6 @@
 // limitations under the License.
 
 // This file is required by karma.conf.js and loads recursively all the .spec and framework files.
-/* tslint:disable */
 // import 'zone.js/dist/zone.js';
 import 'zone.js/dist/async-test';
 import 'zone.js/dist/fake-async-test';
@@ -21,16 +20,13 @@ import 'zone.js/dist/long-stack-trace-zone';
 import 'zone.js/dist/proxy';
 import 'zone.js/dist/sync-test';
 import 'zone.js/dist/jasmine-patch';
-/* tslint:enable */
 
 import {getTestBed} from '@angular/core/testing';
 import {BrowserDynamicTestingModule, platformBrowserDynamicTesting} from '@angular/platform-browser-dynamic/testing';
 
 // Unfortunately there's no typing for the `__karma__` variable. Just declare it as any.
-/* tslint:disable */
 declare const __karma__: any;
 declare const require: any;
-/* tslint:enable */
 
 // Prevent Karma from running prematurely.
 __karma__.loaded = () => {};

src/app/frontend/plugin/holder.ts

@@ -45,7 +45,6 @@ export class PluginHolderComponent implements OnInit {
   loadPlugin(pluginName: string) {
     this.pluginLoader.load(pluginName).then(moduleFactory => {
       const moduleRef = moduleFactory.create(this.injector);
-      // tslint:disable-next-line:no-any
       const entryComponent = (moduleFactory.moduleType as any).entry;
       try {
         const compFactory = moduleRef.componentFactoryResolver.resolveComponentFactory(entryComponent);

src/app/frontend/polyfills.ts

@@ -29,7 +29,6 @@ import 'zone.js/dist/zone';
 // Load `$localize` onto the global scope - used if i18n tags appear in Angular templates.
 import '@angular/localize/init';
 
-/* tslint:disable */
 // Global variable is required by some 3rd party libraries such as 'ace-ui'.
 // It was removed in Angular 6.X, more info can be found here:
 // https://github.com/angular/angular-cli/issues/9827#issuecomment-369578814

src/app/frontend/shell/component.ts

@@ -34,7 +34,6 @@ import {EndpointManager, Resource, Utility} from '../common/services/resource/en
 import {NamespacedResourceService} from '../common/services/resource/resource';
 import {UtilityService} from '../common/services/resource/utility';
 
-// tslint:disable-next-line:no-any
 declare let SockJS: any;
 
 @Component({

src/app/frontend/systemjs.d.ts

@@ -13,12 +13,10 @@
 // limitations under the License.
 
 interface Window {
-  // tslint:disable-next-line:no-any
   define: (name: string, deps: string[], definitionFn: () => any) => void;
 
   System: {
     // @ts-ignore
-    // tslint:disable-next-line:no-any
     import: (path) => Promise<any>;
   };
 }

src/app/frontend/typings/backendapi.ts

@@ -732,13 +732,11 @@ export interface ErrStatus {
   reason: string;
 }
 
-/* tslint:disable */
 export interface K8sError {
   ErrStatus: ErrStatus;
 
   toKdError(): KdError;
 }
-/* tslint:enable */
 
 export interface Condition {
   type: string;
@@ -971,7 +969,6 @@ export interface LocalObjectReference {
   name: string;
 }
 
-/* tslint:disable */
 export interface ISCSIVolumeSource {
   targetPortal: string;
   iqn: string;
@@ -979,7 +976,6 @@ export interface ISCSIVolumeSource {
   fsType: string;
   readOnly: boolean;
 }
-/* tslint:enable */
 
 export interface CinderVolumeSource {
   volumeID: string;