From 213d8601c99a48cb15f8540f3fc5c4ca820c6309 Mon Sep 17 00:00:00 2001 From: bryk Date: Fri, 20 Nov 2015 10:59:30 +0100 Subject: [PATCH] Rename JS files from dot to underscore case This is a required change because with dot case we cannot reference other modules inside JSDoc `@type` annotations. For example, if you want to reference `@type {./deploy.controller.FooType}` does not work, because the compiler does not know whether `deploy` is a module or `deploy.controller`. Changing dot case to undersocre, camel or dash case solves this problem. I decided to go with underscore case because this is what golang uses (e.g., `foo_test.js`) so we'll have higher similarity of backend and frontend codebases. --- .../{chrome.controller.js => chrome_controller.js} | 0 .../{chrome.directive.js => chrome_directive.js} | 2 +- .../chrome/{chrome.module.js => chrome_module.js} | 2 +- .../{deploy.controller.js => deploy_controller.js} | 0 .../deploy/{deploy.module.js => deploy_module.js} | 2 +- .../deploy/{deploy.state.js => deploy_state.js} | 2 +- .../frontend/{index.config.js => index_config.js} | 0 .../frontend/{index.module.js => index_module.js} | 14 +++++++------- .../frontend/{index.route.js => index_route.js} | 0 ...ontroller.js => replicasetdetail_controller.js} | 2 +- ...detail.module.js => replicasetdetail_module.js} | 4 ++-- ...etdetail.state.js => replicasetdetail_state.js} | 2 +- ....controller.js => replicasetlist_controller.js} | 0 ...asetlist.module.js => replicasetlist_module.js} | 2 +- ...icasetlist.state.js => replicasetlist_state.js} | 2 +- ...state.controller.js => zerostate_controller.js} | 0 .../{zerostate.module.js => zerostate_module.js} | 2 +- .../{zerostate.state.js => zerostate_state.js} | 2 +- ...roller.test.js => zerostate_controller_test.js} | 2 +- .../{zerostate.po.js => zerostate_po.js} | 0 .../{zerostate.test.js => zerostate_test.js} | 0 21 files changed, 20 insertions(+), 20 deletions(-) rename src/app/frontend/chrome/{chrome.controller.js => chrome_controller.js} (100%) rename src/app/frontend/chrome/{chrome.directive.js => chrome_directive.js} (94%) rename src/app/frontend/chrome/{chrome.module.js => chrome_module.js} (94%) rename src/app/frontend/deploy/{deploy.controller.js => deploy_controller.js} (100%) rename src/app/frontend/deploy/{deploy.module.js => deploy_module.js} (95%) rename src/app/frontend/deploy/{deploy.state.js => deploy_state.js} (94%) rename src/app/frontend/{index.config.js => index_config.js} (100%) rename src/app/frontend/{index.module.js => index_module.js} (82%) rename src/app/frontend/{index.route.js => index_route.js} (100%) rename src/app/frontend/replicasetdetail/{replicasetdetail.controller.js => replicasetdetail_controller.js} (94%) rename src/app/frontend/replicasetdetail/{replicasetdetail.module.js => replicasetdetail_module.js} (89%) rename src/app/frontend/replicasetdetail/{replicasetdetail.state.js => replicasetdetail_state.js} (94%) rename src/app/frontend/replicasetlist/{replicasetlist.controller.js => replicasetlist_controller.js} (100%) rename src/app/frontend/replicasetlist/{replicasetlist.module.js => replicasetlist_module.js} (94%) rename src/app/frontend/replicasetlist/{replicasetlist.state.js => replicasetlist_state.js} (93%) rename src/app/frontend/zerostate/{zerostate.controller.js => zerostate_controller.js} (100%) rename src/app/frontend/zerostate/{zerostate.module.js => zerostate_module.js} (95%) rename src/app/frontend/zerostate/{zerostate.state.js => zerostate_state.js} (94%) rename src/test/frontend/zerostate/{zerostate.controller.test.js => zerostate_controller_test.js} (94%) rename src/test/integration/{zerostate.po.js => zerostate_po.js} (100%) rename src/test/integration/{zerostate.test.js => zerostate_test.js} (100%) diff --git a/src/app/frontend/chrome/chrome.controller.js b/src/app/frontend/chrome/chrome_controller.js similarity index 100% rename from src/app/frontend/chrome/chrome.controller.js rename to src/app/frontend/chrome/chrome_controller.js diff --git a/src/app/frontend/chrome/chrome.directive.js b/src/app/frontend/chrome/chrome_directive.js similarity index 94% rename from src/app/frontend/chrome/chrome.directive.js rename to src/app/frontend/chrome/chrome_directive.js index 156004b5e..2fff02bd9 100644 --- a/src/app/frontend/chrome/chrome.directive.js +++ b/src/app/frontend/chrome/chrome_directive.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import ChromeController from './chrome.controller'; +import ChromeController from './chrome_controller'; /** diff --git a/src/app/frontend/chrome/chrome.module.js b/src/app/frontend/chrome/chrome_module.js similarity index 94% rename from src/app/frontend/chrome/chrome.module.js rename to src/app/frontend/chrome/chrome_module.js index ab80568b6..ed660e215 100644 --- a/src/app/frontend/chrome/chrome.module.js +++ b/src/app/frontend/chrome/chrome_module.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import chromeDirective from './chrome.directive'; +import chromeDirective from './chrome_directive'; /** diff --git a/src/app/frontend/deploy/deploy.controller.js b/src/app/frontend/deploy/deploy_controller.js similarity index 100% rename from src/app/frontend/deploy/deploy.controller.js rename to src/app/frontend/deploy/deploy_controller.js diff --git a/src/app/frontend/deploy/deploy.module.js b/src/app/frontend/deploy/deploy_module.js similarity index 95% rename from src/app/frontend/deploy/deploy.module.js rename to src/app/frontend/deploy/deploy_module.js index b6f1cf8de..69803dd5e 100644 --- a/src/app/frontend/deploy/deploy.module.js +++ b/src/app/frontend/deploy/deploy_module.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import stateConfig from './deploy.state'; +import stateConfig from './deploy_state'; /** diff --git a/src/app/frontend/deploy/deploy.state.js b/src/app/frontend/deploy/deploy_state.js similarity index 94% rename from src/app/frontend/deploy/deploy.state.js rename to src/app/frontend/deploy/deploy_state.js index be5411c5f..20388a787 100644 --- a/src/app/frontend/deploy/deploy.state.js +++ b/src/app/frontend/deploy/deploy_state.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import DeployController from './deploy.controller'; +import DeployController from './deploy_controller'; /** diff --git a/src/app/frontend/index.config.js b/src/app/frontend/index_config.js similarity index 100% rename from src/app/frontend/index.config.js rename to src/app/frontend/index_config.js diff --git a/src/app/frontend/index.module.js b/src/app/frontend/index_module.js similarity index 82% rename from src/app/frontend/index.module.js rename to src/app/frontend/index_module.js index 2660e8ad7..8e4f9e7d6 100644 --- a/src/app/frontend/index.module.js +++ b/src/app/frontend/index_module.js @@ -16,13 +16,13 @@ * @fileoverview Entry point module to the application. Loads and configures other modules needed * to bootstrap the application. */ -import chromeModule from './chrome/chrome.module'; -import deployModule from './deploy/deploy.module'; -import indexConfig from './index.config'; -import routeConfig from './index.route'; -import replicaSetDetailModule from './replicasetdetail/replicasetdetail.module'; -import replicaSetListModule from './replicasetlist/replicasetlist.module'; -import zerostateModule from './zerostate/zerostate.module'; +import chromeModule from './chrome/chrome_module'; +import deployModule from './deploy/deploy_module'; +import indexConfig from './index_config'; +import routeConfig from './index_route'; +import replicaSetDetailModule from './replicasetdetail/replicasetdetail_module'; +import replicaSetListModule from './replicasetlist/replicasetlist_module'; +import zerostateModule from './zerostate/zerostate_module'; export default angular.module( diff --git a/src/app/frontend/index.route.js b/src/app/frontend/index_route.js similarity index 100% rename from src/app/frontend/index.route.js rename to src/app/frontend/index_route.js diff --git a/src/app/frontend/replicasetdetail/replicasetdetail.controller.js b/src/app/frontend/replicasetdetail/replicasetdetail_controller.js similarity index 94% rename from src/app/frontend/replicasetdetail/replicasetdetail.controller.js rename to src/app/frontend/replicasetdetail/replicasetdetail_controller.js index c940b4d62..8dde7f2b2 100644 --- a/src/app/frontend/replicasetdetail/replicasetdetail.controller.js +++ b/src/app/frontend/replicasetdetail/replicasetdetail_controller.js @@ -18,7 +18,7 @@ * * @final */ -export default class ReplicaSetDetailsController { +export default class ReplicaSetDetailController { /** * @param {!angular.$log} $log * @ngInject diff --git a/src/app/frontend/replicasetdetail/replicasetdetail.module.js b/src/app/frontend/replicasetdetail/replicasetdetail_module.js similarity index 89% rename from src/app/frontend/replicasetdetail/replicasetdetail.module.js rename to src/app/frontend/replicasetdetail/replicasetdetail_module.js index 92c1f56c2..55ff3ea65 100644 --- a/src/app/frontend/replicasetdetail/replicasetdetail.module.js +++ b/src/app/frontend/replicasetdetail/replicasetdetail_module.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import stateConfig from './replicasetdetail.state'; +import stateConfig from './replicasetdetail_state'; /** @@ -21,7 +21,7 @@ import stateConfig from './replicasetdetail.state'; * The view shows detailed view of a Replica Sets. */ export default angular.module( - 'kubernetesDashboard.replicaSetDetails', + 'kubernetesDashboard.replicaSetDetail', [ 'ngMaterial', 'ui.router', diff --git a/src/app/frontend/replicasetdetail/replicasetdetail.state.js b/src/app/frontend/replicasetdetail/replicasetdetail_state.js similarity index 94% rename from src/app/frontend/replicasetdetail/replicasetdetail.state.js rename to src/app/frontend/replicasetdetail/replicasetdetail_state.js index 1c1c6e8e1..5a50a6aeb 100644 --- a/src/app/frontend/replicasetdetail/replicasetdetail.state.js +++ b/src/app/frontend/replicasetdetail/replicasetdetail_state.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import ReplicaSetDetailController from './replicasetdetail.controller'; +import ReplicaSetDetailController from './replicasetdetail_controller'; /** diff --git a/src/app/frontend/replicasetlist/replicasetlist.controller.js b/src/app/frontend/replicasetlist/replicasetlist_controller.js similarity index 100% rename from src/app/frontend/replicasetlist/replicasetlist.controller.js rename to src/app/frontend/replicasetlist/replicasetlist_controller.js diff --git a/src/app/frontend/replicasetlist/replicasetlist.module.js b/src/app/frontend/replicasetlist/replicasetlist_module.js similarity index 94% rename from src/app/frontend/replicasetlist/replicasetlist.module.js rename to src/app/frontend/replicasetlist/replicasetlist_module.js index 53dd1618c..f6254593c 100644 --- a/src/app/frontend/replicasetlist/replicasetlist.module.js +++ b/src/app/frontend/replicasetlist/replicasetlist_module.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import stateConfig from './replicasetlist.state'; +import stateConfig from './replicasetlist_state'; /** diff --git a/src/app/frontend/replicasetlist/replicasetlist.state.js b/src/app/frontend/replicasetlist/replicasetlist_state.js similarity index 93% rename from src/app/frontend/replicasetlist/replicasetlist.state.js rename to src/app/frontend/replicasetlist/replicasetlist_state.js index cb9bd9dc3..f59033c7e 100644 --- a/src/app/frontend/replicasetlist/replicasetlist.state.js +++ b/src/app/frontend/replicasetlist/replicasetlist_state.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import ReplicaSetListController from './replicasetlist.controller'; +import ReplicaSetListController from './replicasetlist_controller'; /** diff --git a/src/app/frontend/zerostate/zerostate.controller.js b/src/app/frontend/zerostate/zerostate_controller.js similarity index 100% rename from src/app/frontend/zerostate/zerostate.controller.js rename to src/app/frontend/zerostate/zerostate_controller.js diff --git a/src/app/frontend/zerostate/zerostate.module.js b/src/app/frontend/zerostate/zerostate_module.js similarity index 95% rename from src/app/frontend/zerostate/zerostate.module.js rename to src/app/frontend/zerostate/zerostate_module.js index bba50dd01..cdb52d30e 100644 --- a/src/app/frontend/zerostate/zerostate.module.js +++ b/src/app/frontend/zerostate/zerostate_module.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import stateConfig from './zerostate.state'; +import stateConfig from './zerostate_state'; /** diff --git a/src/app/frontend/zerostate/zerostate.state.js b/src/app/frontend/zerostate/zerostate_state.js similarity index 94% rename from src/app/frontend/zerostate/zerostate.state.js rename to src/app/frontend/zerostate/zerostate_state.js index c2a8a4dc6..1b02632af 100644 --- a/src/app/frontend/zerostate/zerostate.state.js +++ b/src/app/frontend/zerostate/zerostate_state.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import ZeroStateController from './zerostate.controller'; +import ZeroStateController from './zerostate_controller'; /** diff --git a/src/test/frontend/zerostate/zerostate.controller.test.js b/src/test/frontend/zerostate/zerostate_controller_test.js similarity index 94% rename from src/test/frontend/zerostate/zerostate.controller.test.js rename to src/test/frontend/zerostate/zerostate_controller_test.js index 7f8eae561..995587d39 100644 --- a/src/test/frontend/zerostate/zerostate.controller.test.js +++ b/src/test/frontend/zerostate/zerostate_controller_test.js @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -import ZerostateController from 'zerostate/zerostate.controller'; +import ZerostateController from 'zerostate/zerostate_controller'; describe('Main controller', () => { diff --git a/src/test/integration/zerostate.po.js b/src/test/integration/zerostate_po.js similarity index 100% rename from src/test/integration/zerostate.po.js rename to src/test/integration/zerostate_po.js diff --git a/src/test/integration/zerostate.test.js b/src/test/integration/zerostate_test.js similarity index 100% rename from src/test/integration/zerostate.test.js rename to src/test/integration/zerostate_test.js -- GitLab