From 04a91c45b611d36c832d10ecc1519fe095e0f1f6 Mon Sep 17 00:00:00 2001 From: Anshul Ahuja Date: Tue, 10 Dec 2019 13:29:29 +0530 Subject: [PATCH] Plugin docs-add quotes to build command parameters (#4647) --- docs/plugins/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/plugins/README.md b/docs/plugins/README.md index 2267c437b..4bf6be046 100644 --- a/docs/plugins/README.md +++ b/docs/plugins/README.md @@ -19,8 +19,8 @@ You can clone this repository and checkout to [`plugin/base`](https://github.com On this branch, you can compile the plugin with following command ``` -ng build plugin && ng build --project custom-plugin --prod --modulePath=k8s-plugin#PluginModule --pluginName=k8s-plugin --outputPath=./dist/bundle -ng build --project custom-plugin --prod --modulePath=./plugin1/plugin1.module#Plugin1Module --pluginName=plugin1 --sharedLibs=k8s-plugin --outputPath=./dist/bundle +ng build plugin && ng build --project custom-plugin --prod --modulePath="k8s-plugin#PluginModule" --pluginName="k8s-plugin" --outputPath="./dist/bundle" +ng build --project custom-plugin --prod --modulePath="./plugin1/plugin1.module#Plugin1Module" --pluginName="plugin1" --sharedLibs="k8s-plugin" --outputPath="./dist/bundle" ``` The key thing here is that we specify the `custom-plugin` project in the `angular.json` to use our custom builder. Make sure to keep the config similar when developing your own plugins. @@ -40,8 +40,8 @@ kubectl apply -f https://raw.githubusercontent.com/kubernetes/dashboard/master/a We can now create config-maps to hold the compiled plugin source code. ``` -kubectl create configmap k8s-plugin-src --from-file=./dist/bundle/k8s-plugin.js -kubectl create configmap plugin1-src --from-file=./dist/bundle/plugin1.js +kubectl create configmap k8s-plugin-src --from-file="./dist/bundle/k8s-plugin.js" +kubectl create configmap plugin1-src --from-file="./dist/bundle/plugin1.js" ``` After following all the above steps, your new plugin should be available in the dashboard. -- GitLab