From 8abad65f6b776bd1794d340ca614a5554341369c Mon Sep 17 00:00:00 2001
From: pengys5 <8082209@qq.com>
Date: Fri, 8 Sep 2017 00:35:25 +0800
Subject: [PATCH] Register service do not return the id when value of 0.

---
 .../handler/ApplicationRegisterServiceHandler.java    |  6 ++++--
 .../handler/ServiceNameDiscoveryServiceHandler.java   | 11 +++++++----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/apm-collector/apm-collector-agentregister/src/main/java/org/skywalking/apm/collector/agentregister/grpc/handler/ApplicationRegisterServiceHandler.java b/apm-collector/apm-collector-agentregister/src/main/java/org/skywalking/apm/collector/agentregister/grpc/handler/ApplicationRegisterServiceHandler.java
index 9540d7737..28c1a1539 100644
--- a/apm-collector/apm-collector-agentregister/src/main/java/org/skywalking/apm/collector/agentregister/grpc/handler/ApplicationRegisterServiceHandler.java
+++ b/apm-collector/apm-collector-agentregister/src/main/java/org/skywalking/apm/collector/agentregister/grpc/handler/ApplicationRegisterServiceHandler.java
@@ -29,8 +29,10 @@ public class ApplicationRegisterServiceHandler extends ApplicationRegisterServic
             String applicationCode = applicationCodes.get(i);
             int applicationId = applicationIDService.getOrCreate(applicationCode);
 
-            KeyWithIntegerValue value = KeyWithIntegerValue.newBuilder().setKey(applicationCode).setValue(applicationId).build();
-            builder.addApplication(i, value);
+            if (applicationId != 0) {
+                KeyWithIntegerValue value = KeyWithIntegerValue.newBuilder().setKey(applicationCode).setValue(applicationId).build();
+                builder.addApplication(value);
+            }
         }
         responseObserver.onNext(builder.build());
         responseObserver.onCompleted();
diff --git a/apm-collector/apm-collector-agentregister/src/main/java/org/skywalking/apm/collector/agentregister/grpc/handler/ServiceNameDiscoveryServiceHandler.java b/apm-collector/apm-collector-agentregister/src/main/java/org/skywalking/apm/collector/agentregister/grpc/handler/ServiceNameDiscoveryServiceHandler.java
index 1009658a7..608b7c36d 100644
--- a/apm-collector/apm-collector-agentregister/src/main/java/org/skywalking/apm/collector/agentregister/grpc/handler/ServiceNameDiscoveryServiceHandler.java
+++ b/apm-collector/apm-collector-agentregister/src/main/java/org/skywalking/apm/collector/agentregister/grpc/handler/ServiceNameDiscoveryServiceHandler.java
@@ -30,10 +30,13 @@ public class ServiceNameDiscoveryServiceHandler extends ServiceNameDiscoveryServ
             int applicationId = serviceNameElement.getApplicationId();
             String serviceName = serviceNameElement.getServiceName();
             int serviceId = serviceNameService.getOrCreate(applicationId, serviceName);
-            ServiceNameMappingElement.Builder mappingElement = ServiceNameMappingElement.newBuilder();
-            mappingElement.setServiceId(serviceId);
-            mappingElement.setElement(serviceNameElement);
-            builder.addElements(mappingElement);
+
+            if (serviceId != 0) {
+                ServiceNameMappingElement.Builder mappingElement = ServiceNameMappingElement.newBuilder();
+                mappingElement.setServiceId(serviceId);
+                mappingElement.setElement(serviceNameElement);
+                builder.addElements(mappingElement);
+            }
         }
 
         responseObserver.onNext(builder.build());
-- 
GitLab