From ff216da505b5d270ed3dcba43d0c451376740db7 Mon Sep 17 00:00:00 2001 From: isidor Date: Tue, 5 Apr 2016 00:27:39 +0200 Subject: [PATCH] debug: ux polish for stack frame paging #4792 --- src/vs/workbench/parts/debug/browser/debugViewer.ts | 2 +- src/vs/workbench/parts/debug/browser/debugViewlet.ts | 7 ++++++- .../workbench/parts/debug/browser/media/debugViewlet.css | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/parts/debug/browser/debugViewer.ts b/src/vs/workbench/parts/debug/browser/debugViewer.ts index 48b7e7fb5d8..a13b37fb78b 100644 --- a/src/vs/workbench/parts/debug/browser/debugViewer.ts +++ b/src/vs/workbench/parts/debug/browser/debugViewer.ts @@ -319,7 +319,7 @@ export class CallStackRenderer implements tree.IRenderer { } private renderLoadMore(element: any, data: ILoadMoreTemplateData): void { - data.label.textContent = nls.localize('loadMoreStackFrames', "Load More Stack Frames..."); + data.label.textContent = nls.localize('loadMoreStackFrames', "Load More Stack Frames"); } private renderStackFrame(stackFrame: debug.IStackFrame, data: IStackFrameTemplateData): void { diff --git a/src/vs/workbench/parts/debug/browser/debugViewlet.ts b/src/vs/workbench/parts/debug/browser/debugViewlet.ts index 5b707cce3a7..a5a6c297bcf 100644 --- a/src/vs/workbench/parts/debug/browser/debugViewlet.ts +++ b/src/vs/workbench/parts/debug/browser/debugViewlet.ts @@ -265,7 +265,12 @@ class CallStackView extends viewlet.CollapsibleViewletView { if (typeof element === 'number') { const thread = this.debugService.getModel().getThreads()[element]; if (thread) { - thread.getCallStack(this.debugService, true).then(() => this.tree.refresh()).done(null, errors.onUnexpectedError); + thread.getCallStack(this.debugService, true) + .then(() => this.tree.refresh()) + .then(() => { + this.tree.clearFocus(); + this.tree.clearSelection(); + }).done(null, errors.onUnexpectedError); } } })); diff --git a/src/vs/workbench/parts/debug/browser/media/debugViewlet.css b/src/vs/workbench/parts/debug/browser/media/debugViewlet.css index 6182957949e..55aadbbe82d 100644 --- a/src/vs/workbench/parts/debug/browser/media/debugViewlet.css +++ b/src/vs/workbench/parts/debug/browser/media/debugViewlet.css @@ -160,6 +160,7 @@ .debug-viewlet .debug-call-stack .load-more { font-style: italic; + text-align: center; } /* Variables & Expression view */ -- GitLab