From f781afbd2198a9579c1040338a2807f7cb5c4f1a Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Fri, 20 May 2016 14:24:35 -0700 Subject: [PATCH] Allow externalTerminal.windowExec to work with spaces Fixes #6590 --- .../parts/execution/electron-browser/terminalService.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/execution/electron-browser/terminalService.ts b/src/vs/workbench/parts/execution/electron-browser/terminalService.ts index 4fb5557836d..927a0fb3cbc 100644 --- a/src/vs/workbench/parts/execution/electron-browser/terminalService.ts +++ b/src/vs/workbench/parts/execution/electron-browser/terminalService.ts @@ -32,7 +32,9 @@ export class WinTerminalService implements ITerminalService { private spawnTerminal(spawner, configuration: ITerminalConfiguration, command: string, path?: string): TPromise { let terminalConfig = configuration.externalTerminal; let exec = terminalConfig.windowsExec || DEFAULT_TERMINAL_WINDOWS; - let cmdArgs = ['/c', 'start', '/wait', exec]; + // The '""' argument is the window title. Without this, exec doesn't work when the path + // contains spaces + let cmdArgs = ['/c', 'start', '/wait', '""', exec]; return new TPromise((c, e) => { let env = path ? { cwd: path } : void 0; -- GitLab