From f6ab4302c560ad179132c1123e3a3b2a4314a2fb Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Fri, 9 Nov 2018 10:21:51 +0100 Subject: [PATCH] #53526 Migrate away from TPromise in Problems panel --- .../workbench/parts/markers/electron-browser/markersPanel.ts | 4 +--- .../parts/markers/electron-browser/markersPanelActions.ts | 5 ++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/vs/workbench/parts/markers/electron-browser/markersPanel.ts b/src/vs/workbench/parts/markers/electron-browser/markersPanel.ts index 0e53bca9dc2..aec7d75ffda 100644 --- a/src/vs/workbench/parts/markers/electron-browser/markersPanel.ts +++ b/src/vs/workbench/parts/markers/electron-browser/markersPanel.ts @@ -6,7 +6,6 @@ import 'vs/css!./media/markers'; import { URI } from 'vs/base/common/uri'; -import { TPromise } from 'vs/base/common/winjs.base'; import * as dom from 'vs/base/browser/dom'; import { IAction, IActionItem, Action } from 'vs/base/common/actions'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; @@ -202,7 +201,7 @@ export class MarkersPanel extends Panel implements IMarkerFilterController { return false; } - private refreshPanel(): TPromise { + private refreshPanel(): void { if (this.isVisible()) { this.cachedFilterStats = undefined; this.tree.setChildren(null, createModelIterator(this.markersWorkbenchService.markersModel)); @@ -212,7 +211,6 @@ export class MarkersPanel extends Panel implements IMarkerFilterController { this.renderMessage(); this._onDidFilter.fire(); } - return TPromise.as(null); } private updateFilter() { diff --git a/src/vs/workbench/parts/markers/electron-browser/markersPanelActions.ts b/src/vs/workbench/parts/markers/electron-browser/markersPanelActions.ts index 3cd2f27c7ce..6c37bb1098f 100644 --- a/src/vs/workbench/parts/markers/electron-browser/markersPanelActions.ts +++ b/src/vs/workbench/parts/markers/electron-browser/markersPanelActions.ts @@ -5,7 +5,6 @@ import { Delayer } from 'vs/base/common/async'; import * as DOM from 'vs/base/browser/dom'; -import { TPromise } from 'vs/base/common/winjs.base'; import { Action, IAction, IActionChangeEvent } from 'vs/base/common/actions'; import { HistoryInputBox } from 'vs/base/browser/ui/inputbox/inputBox'; import { KeyCode } from 'vs/base/common/keyCodes'; @@ -69,7 +68,7 @@ export class ShowProblemsPanelAction extends Action { super(id, label); } - public run(): TPromise { + public run(): Thenable { this.panelService.openPanel(Constants.MARKERS_PANEL_ID, true); return Promise.resolve(null); } @@ -347,7 +346,7 @@ export class QuickFixAction extends Action { })); } - public openFileAtMarker(element: Marker): TPromise { + public openFileAtMarker(element: Marker): Thenable { const { resource, selection } = { resource: element.resource, selection: element.range }; return this.editorService.openEditor({ resource, -- GitLab