From e909a0d91d5377d35aa15ae51d3e368dbf0d5d6c Mon Sep 17 00:00:00 2001
From: Benjamin Pasero <benjpas@microsoft.com>
Date: Tue, 19 Jun 2018 11:56:26 +0200
Subject: [PATCH] fix #52201

---
 .../feedback/electron-browser/feedback.ts     | 23 ++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/vs/workbench/parts/feedback/electron-browser/feedback.ts b/src/vs/workbench/parts/feedback/electron-browser/feedback.ts
index 08a18f96c24..e2623a7b857 100644
--- a/src/vs/workbench/parts/feedback/electron-browser/feedback.ts
+++ b/src/vs/workbench/parts/feedback/electron-browser/feedback.ts
@@ -139,8 +139,12 @@ export class FeedbackDropdown extends Dropdown {
 
 		$('h2.title').text(nls.localize("label.sendASmile", "Tweet us your feedback.")).appendTo($form);
 
-		const cancelBtn = $('div.cancel').attr('tabindex', '0');
-		cancelBtn.on(dom.EventType.MOUSE_OVER, () => {
+		const closeBtn = $('div.cancel').attr({
+			'tabindex': '0',
+			'role': 'button',
+			'title': nls.localize('close', "Close")
+		});
+		closeBtn.on(dom.EventType.MOUSE_OVER, () => {
 			const theme = this.themeService.getTheme();
 			let darkenFactor: number;
 			switch (theme.type) {
@@ -153,13 +157,13 @@ export class FeedbackDropdown extends Dropdown {
 			}
 
 			if (darkenFactor) {
-				cancelBtn.getHTMLElement().style.backgroundColor = darken(theme.getColor(editorWidgetBackground), darkenFactor)(theme).toString();
+				closeBtn.getHTMLElement().style.backgroundColor = darken(theme.getColor(editorWidgetBackground), darkenFactor)(theme).toString();
 			}
 		});
-		cancelBtn.on(dom.EventType.MOUSE_OUT, () => {
-			cancelBtn.getHTMLElement().style.backgroundColor = null;
+		closeBtn.on(dom.EventType.MOUSE_OUT, () => {
+			closeBtn.getHTMLElement().style.backgroundColor = null;
 		});
-		this.invoke(cancelBtn, () => {
+		this.invoke(closeBtn, () => {
 			this.hide();
 		}).appendTo($form);
 
@@ -178,7 +182,8 @@ export class FeedbackDropdown extends Dropdown {
 
 		this.smileyInput = $('div').addClass('sentiment smile').attr({
 			'aria-checked': 'false',
-			'aria-label': nls.localize('smileCaption', "Happy"),
+			'aria-label': nls.localize('smileCaption', "Happy Feedback Sentiment"),
+			'title': nls.localize('smileCaption', "Happy Feedback Sentiment"),
 			'tabindex': 0,
 			'role': 'checkbox'
 		});
@@ -186,7 +191,8 @@ export class FeedbackDropdown extends Dropdown {
 
 		this.frownyInput = $('div').addClass('sentiment frown').attr({
 			'aria-checked': 'false',
-			'aria-label': nls.localize('frownCaption', "Sad"),
+			'aria-label': nls.localize('frownCaption', "Sad Feedback Sentiment"),
+			'title': nls.localize('frownCaption', "Sad Feedback Sentiment"),
 			'tabindex': 0,
 			'role': 'checkbox'
 		});
@@ -254,6 +260,7 @@ export class FeedbackDropdown extends Dropdown {
 		this.sendButton.label = nls.localize('tweet', "Tweet");
 		this.$sendButton = new Builder(this.sendButton.element);
 		this.$sendButton.addClass('send');
+		this.$sendButton.title(nls.localize('tweetFeedback', "Tweet Feedback"));
 		this.toDispose.push(attachButtonStyler(this.sendButton, this.themeService));
 
 		this.sendButton.onDidClick(() => {
-- 
GitLab