From e6ef901bda180499afa5245cdc8a782eac3e4635 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Fri, 14 Sep 2018 09:09:11 -0700 Subject: [PATCH] Wait to call registerOnDataListener until the terminal id has been set (#58644) --- src/vs/workbench/api/node/extHostTerminalService.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/api/node/extHostTerminalService.ts b/src/vs/workbench/api/node/extHostTerminalService.ts index 7534a42c355..82b27ae509b 100644 --- a/src/vs/workbench/api/node/extHostTerminalService.ts +++ b/src/vs/workbench/api/node/extHostTerminalService.ts @@ -77,7 +77,9 @@ export class ExtHostTerminal extends BaseExtHostTerminal implements vscode.Termi private readonly _onData: Emitter = new Emitter(); public get onDidWriteData(): Event { // Tell the main side to start sending data if it's not already - this._proxy.$registerOnDataListener(this._id); + this._idPromise.then(c => { + this._proxy.$registerOnDataListener(this._id); + }); return this._onData && this._onData.event; } -- GitLab