From e3e972589db57a16da6426828706ced9c2d52848 Mon Sep 17 00:00:00 2001 From: rebornix Date: Thu, 9 Aug 2018 15:43:56 -0700 Subject: [PATCH] Fix microsoft/vscode-pull-request-github#149. Ctrl+Enter to submit the comment. --- .../comments/electron-browser/commentThreadWidget.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/comments/electron-browser/commentThreadWidget.ts b/src/vs/workbench/parts/comments/electron-browser/commentThreadWidget.ts index 80acb6b6adc..e859e123b94 100644 --- a/src/vs/workbench/parts/comments/electron-browser/commentThreadWidget.ts +++ b/src/vs/workbench/parts/comments/electron-browser/commentThreadWidget.ts @@ -366,6 +366,11 @@ export class ReviewZoneWidget extends ZoneWidget { this.dispose(); } } + + if (this._commentEditor.getModel().getValueLength() !== 0 && ev.keyCode === KeyCode.Enter && ev.ctrlKey) { + let lineNumber = this._commentGlyph.getPosition().position.lineNumber; + this.createComment(lineNumber); + } })); this._error = $('.validation-error.hidden').appendTo(this._commentForm).getHTMLElement(); @@ -386,6 +391,7 @@ export class ReviewZoneWidget extends ZoneWidget { })); button.onDidClick(async () => { + let lineNumber = this._commentGlyph.getPosition().position.lineNumber; this.createComment(lineNumber); }); @@ -501,7 +507,7 @@ export class ReviewZoneWidget extends ZoneWidget { if (model) { let valueLength = model.getValueLength(); const hasExistingComments = this._commentThread.comments.length > 0; - let placeholder = valueLength > 0 ? '' : (hasExistingComments ? 'Reply...' : 'Type a new comment'); + let placeholder = valueLength > 0 ? '' : (hasExistingComments ? 'Reply... (press Ctrl+Enter to submit)' : 'Type a new comment (press Ctrl+Enter to submit)'); const decorations = [{ range: { startLineNumber: 0, -- GitLab