From d57b158fc06097ec2dc13a96c0e0f98e8865b289 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Thu, 28 Mar 2019 11:07:10 +0100 Subject: [PATCH] Revert "Fix bad merge that caused reoccurance of 'Failed to create terminal for task'" This was a mistake. There wasn't a bad merge. This reverts commit 185e7002cbf1ef23d59d79bb3f99902c494f526c. --- src/vs/workbench/contrib/tasks/common/taskConfiguration.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts b/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts index f187a4e2e8a..dad7b3896f5 100644 --- a/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts +++ b/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts @@ -930,9 +930,6 @@ namespace CommandConfiguration { function fromBase(this: void, config: BaseCommandConfiguationShape, context: ParseContext): Tasks.CommandConfiguration | undefined { let name: Tasks.CommandString | undefined = ShellString.from(config.command); - if (name === undefined) { - return undefined; - } let runtime: Tasks.RuntimeType; if (Types.isString(config.type)) { if (config.type === 'shell' || config.type === 'process') { -- GitLab