diff --git a/src/vs/editor/contrib/suggest/common/suggest.ts b/src/vs/editor/contrib/suggest/common/suggest.ts index 0a1e2189beebca383980481f9758c9c7542c1f0d..5d65a6946ab4df5bec768c0204381880ba0ff9ca 100644 --- a/src/vs/editor/contrib/suggest/common/suggest.ts +++ b/src/vs/editor/contrib/suggest/common/suggest.ts @@ -31,7 +31,7 @@ export interface ISuggestionItem { resolve(): TPromise; } -export type SnippetConfig = 'top' | 'bottom' | 'inline' | 'none' | 'only'; +export type SnippetConfig = 'top' | 'bottom' | 'inline' | 'none'; export interface ISuggestOptions { groups?: ISuggestSupport[][]; @@ -122,12 +122,10 @@ function createSuggestionResolver(provider: ISuggestSupport, suggestion: ISugges } function createSuggesionFilter(options: ISuggestOptions): (candidate: ISuggestion) => boolean { - if (options.snippetConfig === 'only') { - return suggestion => suggestion.type === 'snippet'; - } else if (options.snippetConfig === 'none') { + if (options.snippetConfig === 'none') { return suggestion => suggestion.type !== 'snippet'; } else { - return _ => true; + return () => true; } } diff --git a/src/vs/editor/contrib/suggest/test/common/suggest.test.ts b/src/vs/editor/contrib/suggest/test/common/suggest.test.ts index 756514613e90b0a8f6c141e27d6f03a7d92c2907..9078e2136b0685d8eda77e684568ded1ea8906ff 100644 --- a/src/vs/editor/contrib/suggest/test/common/suggest.test.ts +++ b/src/vs/editor/contrib/suggest/test/common/suggest.test.ts @@ -83,13 +83,4 @@ suite('Suggest', function () { assert.equal(items[0].suggestion.label, 'fff'); }); }); - - test('sort - snippet top', function () { - return provideSuggestionItems(model, new Position(1, 1), { snippetConfig: 'only' }).then(items => { - assert.equal(items.length, 2); - assert.equal(items[0].suggestion.label, 'aaa'); - assert.equal(items[1].suggestion.label, 'zzz'); - }); - }); - }); \ No newline at end of file