From c5b902b16984cc24268bab1e96334c605ad4428b Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Wed, 11 Jul 2018 10:50:12 +0200 Subject: [PATCH] don't pollute context view dom node --- .../workbench/browser/parts/editor/breadcrumbsControl.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts b/src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts index 203fb414cfb..6990ff52921 100644 --- a/src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts +++ b/src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts @@ -220,14 +220,16 @@ export class BreadcrumbsControl { getAnchor() { return event.node; }, - render: (container: HTMLElement) => { - dom.addClasses(container, 'monaco-breadcrumbs-picker', 'monaco-workbench', 'show-file-icons'); + render: (parent: HTMLElement) => { + const container = document.createElement('div'); + parent.appendChild(container); const theme = this._themeService.getTheme(); const color = theme.getColor(editorBackground).darken(theme.type === 'dark' ? .2 : .1); container.style.borderColor = color.toString(); container.style.boxShadow = `2px 2px 3px ${color.toString()}`; container.style.position = 'absolute'; container.style.zIndex = '1000'; + dom.addClasses(container, 'monaco-breadcrumbs-picker', 'monaco-workbench', 'show-file-icons'); let { element } = event.item as Item; let ctor: IConstructorSignature2 = element instanceof FileElement ? BreadcrumbsFilePicker : BreadcrumbsOutlinePicker; @@ -303,8 +305,8 @@ export abstract class BreadcrumbsPicker { this.focus = dom.trackFocus(this._domNode); this.focus.onDidBlur(_ => this._onDidPickElement.fire(undefined), undefined, this._disposables); this._tree.setInput(this._getInput(input)).then(_ => { - this._tree.domFocus(); this._tree.focusFirst(); + this._tree.domFocus(); }, onUnexpectedError); } -- GitLab