From b498b7d2eafc31ac69f83c3c6eaa29d54919d272 Mon Sep 17 00:00:00 2001
From: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Date: Mon, 25 Oct 2021 15:08:43 -0700
Subject: [PATCH] Note in all Pseudoterminal events that open needs to be
 called first

Fixes #108298
---
 src/vs/vscode.d.ts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts
index 0b03428ebcd..4cf784d6129 100644
--- a/src/vs/vscode.d.ts
+++ b/src/vs/vscode.d.ts
@@ -9724,6 +9724,8 @@ declare module 'vscode' {
 		 * Note writing `\n` will just move the cursor down 1 row, you need to write `\r` as well
 		 * to move the cursor to the left-most cell.
 		 *
+		 * Events fired before {@link Pseudoterminal.open} is called will be be ignored.
+		 *
 		 * **Example:** Write red text to the terminal
 		 * ```typescript
 		 * const writeEmitter = new vscode.EventEmitter<string>();
@@ -9749,6 +9751,8 @@ declare module 'vscode' {
 		 * bar). Set to `undefined` for the terminal to go back to the regular dimensions (fit to
 		 * the size of the panel).
 		 *
+		 * Events fired before {@link Pseudoterminal.open} is called will be be ignored.
+		 *
 		 * **Example:** Override the dimensions of a terminal to 20 columns and 10 rows
 		 * ```typescript
 		 * const dimensionsEmitter = new vscode.EventEmitter<vscode.TerminalDimensions>();
@@ -9771,6 +9775,8 @@ declare module 'vscode' {
 		/**
 		 * An event that when fired will signal that the pty is closed and dispose of the terminal.
 		 *
+		 * Events fired before {@link Pseudoterminal.open} is called will be be ignored.
+		 *
 		 * A number can be used to provide an exit code for the terminal. Exit codes must be
 		 * positive and a non-zero exit codes signals failure which shows a notification for a
 		 * regular terminal and allows dependent tasks to proceed when used with the
@@ -9800,6 +9806,8 @@ declare module 'vscode' {
 		/**
 		 * An event that when fired allows changing the name of the terminal.
 		 *
+		 * Events fired before {@link Pseudoterminal.open} is called will be be ignored.
+		 *
 		 * **Example:** Change the terminal name to "My new terminal".
 		 * ```typescript
 		 * const writeEmitter = new vscode.EventEmitter<string>();
-- 
GitLab