From b2fd3101ebffc382d5583ea2917520167f3f1255 Mon Sep 17 00:00:00 2001 From: jeanp413 Date: Sun, 23 Jun 2019 16:10:20 -0500 Subject: [PATCH] Stop event propagation in `onEditSettingClicked`. Fixes #75947 --- .../contrib/preferences/browser/preferencesRenderers.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/preferences/browser/preferencesRenderers.ts b/src/vs/workbench/contrib/preferences/browser/preferencesRenderers.ts index 6e820f58d02..cd62e03a9a9 100644 --- a/src/vs/workbench/contrib/preferences/browser/preferencesRenderers.ts +++ b/src/vs/workbench/contrib/preferences/browser/preferencesRenderers.ts @@ -4,7 +4,7 @@ *--------------------------------------------------------------------------------------------*/ import { ContextSubMenu } from 'vs/base/browser/contextmenu'; -import { getDomNodePagePosition } from 'vs/base/browser/dom'; +import { EventHelper, getDomNodePagePosition } from 'vs/base/browser/dom'; import { IAction } from 'vs/base/common/actions'; import { Delayer } from 'vs/base/common/async'; import { Emitter, Event } from 'vs/base/common/event'; @@ -820,6 +820,8 @@ class EditSettingRenderer extends Disposable { } private onEditSettingClicked(editPreferenceWidget: EditPreferenceWidget, e: IEditorMouseEvent): void { + EventHelper.stop(e.event, true); + const anchor = { x: e.event.posx, y: e.event.posy + 10 }; const actions = this.getSettings(editPreferenceWidget.getLine()).length === 1 ? this.getActions(editPreferenceWidget.preferences[0], this.getConfigurationsMap()[editPreferenceWidget.preferences[0].key]) : editPreferenceWidget.preferences.map(setting => new ContextSubMenu(setting.key, this.getActions(setting, this.getConfigurationsMap()[setting.key]))); -- GitLab