From b1cc72e504404c953cbca12fc94bb898f10d6361 Mon Sep 17 00:00:00 2001 From: isidor Date: Tue, 21 Feb 2017 12:39:59 +0100 Subject: [PATCH] Doubleclick on debug views (stack, breakpoint) should open pinned and move focus fixes #20984 --- src/vs/workbench/parts/debug/common/debugModel.ts | 3 ++- .../workbench/parts/debug/electron-browser/debugViewer.ts | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/parts/debug/common/debugModel.ts b/src/vs/workbench/parts/debug/common/debugModel.ts index c9944c7c90b..f9459465a9e 100644 --- a/src/vs/workbench/parts/debug/common/debugModel.ts +++ b/src/vs/workbench/parts/debug/common/debugModel.ts @@ -374,7 +374,8 @@ export class StackFrame implements debug.IStackFrame { preserveFocus, selection: { startLineNumber: this.lineNumber, startColumn: 1 }, revealIfVisible: true, - revealInCenterIfOutsideViewport: true + revealInCenterIfOutsideViewport: true, + pinned: !preserveFocus } }, sideBySide); } diff --git a/src/vs/workbench/parts/debug/electron-browser/debugViewer.ts b/src/vs/workbench/parts/debug/electron-browser/debugViewer.ts index d3c44290f39..26d911e1e5f 100644 --- a/src/vs/workbench/parts/debug/electron-browser/debugViewer.ts +++ b/src/vs/workbench/parts/debug/electron-browser/debugViewer.ts @@ -247,7 +247,7 @@ export class CallStackController extends BaseDebugController { return this.showMoreStackFrames(tree, element); } if (element instanceof StackFrame) { - this.focusStackFrame(element, event, true); + this.focusStackFrame(element, event, event.detail !== 2); } return super.onLeftClick(tree, element, event); @@ -1234,7 +1234,7 @@ export class BreakpointsController extends BaseDebugController { return true; } if (element instanceof Breakpoint) { - this.openBreakpointSource(element, event, true); + this.openBreakpointSource(element, event, event.detail !== 2); } return super.onLeftClick(tree, element, event); @@ -1248,7 +1248,8 @@ export class BreakpointsController extends BaseDebugController { preserveFocus, selection: { startLineNumber: breakpoint.lineNumber, startColumn: 1 }, revealIfVisible: true, - revealInCenterIfOutsideViewport: true + revealInCenterIfOutsideViewport: true, + pinned: !preserveFocus } }, sideBySide).done(undefined, errors.onUnexpectedError); } -- GitLab