From 9be8c03040366875bb555904776748673558d783 Mon Sep 17 00:00:00 2001 From: isidor Date: Mon, 15 Feb 2016 13:01:50 +0100 Subject: [PATCH] debug: do not send breakpoints to adapter if file is dirty fixes #2975 --- src/vs/workbench/parts/debug/common/debug.ts | 5 ++++- .../workbench/parts/debug/electron-browser/debugService.ts | 4 +--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/parts/debug/common/debug.ts b/src/vs/workbench/parts/debug/common/debug.ts index 51f3b14a5ca..27a9e05673e 100644 --- a/src/vs/workbench/parts/debug/common/debug.ts +++ b/src/vs/workbench/parts/debug/common/debug.ts @@ -233,7 +233,10 @@ export interface IDebugService extends ee.IEventEmitter { setFocusedStackFrameAndEvaluate(focusedStackFrame: IStackFrame): void; - setBreakpointsForModel(modelUri: uri, data: IRawBreakpoint[]): TPromise; + /** + * Sets breakpoints for a model. Does not send them to the adapter. + */ + setBreakpointsForModel(modelUri: uri, rawData: IRawBreakpoint[]): void; toggleBreakpoint(IRawBreakpoint): TPromise; enableOrDisableAllBreakpoints(enabled: boolean): TPromise; toggleEnablement(element: IEnablement): TPromise; diff --git a/src/vs/workbench/parts/debug/electron-browser/debugService.ts b/src/vs/workbench/parts/debug/electron-browser/debugService.ts index 1a1dee4e9bb..61ee5f94d88 100644 --- a/src/vs/workbench/parts/debug/electron-browser/debugService.ts +++ b/src/vs/workbench/parts/debug/electron-browser/debugService.ts @@ -394,12 +394,10 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService } } - public setBreakpointsForModel(modelUri: uri, rawData: debug.IRawBreakpoint[]): TPromise { + public setBreakpointsForModel(modelUri: uri, rawData: debug.IRawBreakpoint[]): void { this.model.removeBreakpoints( this.model.getBreakpoints().filter(bp => bp.source.uri.toString() === modelUri.toString())); this.model.addBreakpoints(rawData); - - return this.sendBreakpoints(modelUri); } public toggleBreakpoint(rawBreakpoint: debug.IRawBreakpoint): TPromise { -- GitLab