From 97af4fb370aef8f7bccc74594dbfccd4cbf1458b Mon Sep 17 00:00:00 2001 From: rebornix Date: Thu, 24 Sep 2020 15:00:18 -0700 Subject: [PATCH] re #103454. notebook/comments/find remove toggle. --- .../codeEditor/browser/find/simpleFindReplaceWidget.ts | 2 +- src/vs/workbench/contrib/comments/browser/commentsView.ts | 6 +++--- .../contrib/notebook/browser/notebookEditorWidget.ts | 4 ++-- .../browser/view/output/transforms/richTransform.ts | 4 ++-- .../contrib/notebook/browser/view/renderers/cellRenderer.ts | 4 ++-- .../contrib/notebook/browser/view/renderers/codeCell.ts | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindReplaceWidget.ts b/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindReplaceWidget.ts index c9866a9d8df..ad05b40ac5b 100644 --- a/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindReplaceWidget.ts +++ b/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindReplaceWidget.ts @@ -314,7 +314,7 @@ export abstract class SimpleFindReplaceWidget extends Widget { this._replaceBtn.setEnabled(this._isVisible && this._isReplaceVisible && findInputIsNonEmpty); this._replaceAllBtn.setEnabled(this._isVisible && this._isReplaceVisible && findInputIsNonEmpty); - dom.toggleClass(this._domNode, 'replaceToggled', this._isReplaceVisible); + this._domNode.classList.toggle('replaceToggled', this._isReplaceVisible); this._toggleReplaceBtn.setExpanded(this._isReplaceVisible); } diff --git a/src/vs/workbench/contrib/comments/browser/commentsView.ts b/src/vs/workbench/contrib/comments/browser/commentsView.ts index 026a98b0696..3f061246334 100644 --- a/src/vs/workbench/contrib/comments/browser/commentsView.ts +++ b/src/vs/workbench/contrib/comments/browser/commentsView.ts @@ -113,7 +113,7 @@ export class CommentsPanel extends ViewPane { } private async renderComments(): Promise { - dom.toggleClass(this.treeContainer, 'hidden', !this.commentsModel.hasCommentThreads()); + this.treeContainer.classList.toggle('hidden', !this.commentsModel.hasCommentThreads()); await this.tree.setInput(this.commentsModel); this.renderMessage(); } @@ -144,7 +144,7 @@ export class CommentsPanel extends ViewPane { private renderMessage(): void { this.messageBox.textContent = this.commentsModel.getMessage(); - dom.toggleClass(this.messageBoxContainer, 'hidden', this.commentsModel.hasCommentThreads()); + this.messageBoxContainer.classList.toggle('hidden', this.commentsModel.hasCommentThreads()); } private createTree(): void { @@ -237,7 +237,7 @@ export class CommentsPanel extends ViewPane { this.collapseAllAction.enabled = this.commentsModel.hasCommentThreads(); } - dom.toggleClass(this.treeContainer, 'hidden', !this.commentsModel.hasCommentThreads()); + this.treeContainer.classList.toggle('hidden', !this.commentsModel.hasCommentThreads()); this.tree.updateChildren().then(() => { this.renderMessage(); }, (e) => { diff --git a/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts b/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts index df7cf772489..bb8ac657a0e 100644 --- a/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts +++ b/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts @@ -861,8 +861,8 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditor const notebookMetadata = this.viewModel!.metadata; this._editorEditable?.set(!!notebookMetadata?.editable); this._editorRunnable?.set(!!notebookMetadata?.runnable); - DOM.toggleClass(this._overlayContainer, 'notebook-editor-editable', !!notebookMetadata?.editable); - DOM.toggleClass(this.getDomNode(), 'notebook-editor-editable', !!notebookMetadata?.editable); + this._overflowContainer.classList.toggle('notebook-editor-editable', !!notebookMetadata?.editable); + this.getDomNode().classList.toggle('notebook-editor-editable', !!notebookMetadata?.editable); this._notebookExecuting?.set(notebookMetadata.runState === NotebookRunState.Running); } diff --git a/src/vs/workbench/contrib/notebook/browser/view/output/transforms/richTransform.ts b/src/vs/workbench/contrib/notebook/browser/view/output/transforms/richTransform.ts index b7276425242..067515c53ad 100644 --- a/src/vs/workbench/contrib/notebook/browser/view/output/transforms/richTransform.ts +++ b/src/vs/workbench/contrib/notebook/browser/view/output/transforms/richTransform.ts @@ -186,7 +186,7 @@ class RichRenderer implements IOutputTransformContribution { const image = document.createElement('img'); image.src = `data:image/png;base64,${output.data['image/png']}`; const display = document.createElement('div'); - DOM.addClasses(display, 'display'); + display.classList.add('display'); display.appendChild(image); container.appendChild(display); return { type: RenderOutputType.None, hasDynamicHeight: true }; @@ -196,7 +196,7 @@ class RichRenderer implements IOutputTransformContribution { const image = document.createElement('img'); image.src = `data:image/jpeg;base64,${output.data['image/jpeg']}`; const display = document.createElement('div'); - DOM.addClasses(display, 'display'); + display.classList.add('display'); display.appendChild(image); container.appendChild(display); return { type: RenderOutputType.None, hasDynamicHeight: true }; diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts index 22e63d148ba..da6c7d26b13 100644 --- a/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts +++ b/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts @@ -785,7 +785,7 @@ export class CodeCellRenderer extends AbstractCellRenderer implements IListRende private updateForMetadata(element: CodeCellViewModel, templateData: CodeCellRenderTemplate): void { const metadata = element.getEvaluatedMetadata(this.notebookEditor.viewModel!.notebookDocument.metadata); - DOM.toggleClass(templateData.container, 'runnable', !!metadata.runnable); + templateData.container.classList.toggle('runnable', !!metadata.runnable); this.updateExecutionOrder(metadata, templateData); templateData.statusBar.cellStatusMessageContainer.textContent = metadata?.statusMessage || ''; @@ -826,7 +826,7 @@ export class CodeCellRenderer extends AbstractCellRenderer implements IListRende } private updateForHover(element: CodeCellViewModel, templateData: CodeCellRenderTemplate): void { - DOM.toggleClass(templateData.container, 'cell-output-hover', element.outputIsHovered); + templateData.container.classList.toggle('cell-output-hover', element.outputIsHovered); } private updateForLayout(element: CodeCellViewModel, templateData: CodeCellRenderTemplate): void { diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts index 8d5dbd00054..fb720668009 100644 --- a/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts +++ b/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts @@ -84,7 +84,7 @@ export class CodeCell extends Disposable { templateData.editor?.focus(); } - DOM.toggleClass(templateData.container, 'cell-editor-focus', viewCell.focusMode === CellFocusMode.Editor); + templateData.container.classList.toggle('cell-editor-focus', viewCell.focusMode === CellFocusMode.Editor); }; const updateForCollapseState = () => { this.viewUpdate(); -- GitLab