From 972096c90c23e38c668df6d819fdc38238564b32 Mon Sep 17 00:00:00 2001 From: Ramya Rao Date: Thu, 1 Nov 2018 10:14:35 -0700 Subject: [PATCH] Skip malicious check when --disable-extensions (#62351) * Skip malicious check when --disable-extensions * Refactor as per review comments --- .../extensions/electron-browser/extensionsViewlet.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsViewlet.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsViewlet.ts index 19c0c42057f..826e074323b 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionsViewlet.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsViewlet.ts @@ -55,6 +55,7 @@ import { Query } from 'vs/workbench/parts/extensions/common/extensionQuery'; import { SuggestEnabledInput, attachSuggestEnabledInputBoxStyler } from 'vs/workbench/parts/codeEditor/electron-browser/suggestEnabledInput'; import { alert } from 'vs/base/browser/ui/aria/aria'; import { createErrorWithActions } from 'vs/base/common/errorsWithActions'; +import { IEnvironmentService } from 'vs/platform/environment/common/environment'; interface SearchInputEvent extends Event { target: HTMLInputElement; @@ -608,9 +609,12 @@ export class MaliciousExtensionChecker implements IWorkbenchContribution { @IExtensionManagementService private extensionsManagementService: IExtensionManagementService, @IWindowService private windowService: IWindowService, @ILogService private logService: ILogService, - @INotificationService private notificationService: INotificationService + @INotificationService private notificationService: INotificationService, + @IEnvironmentService private environmentService: IEnvironmentService ) { - this.loopCheckForMaliciousExtensions(); + if (!this.environmentService.disableExtensions) { + this.loopCheckForMaliciousExtensions(); + } } private loopCheckForMaliciousExtensions(): void { -- GitLab