From 87668839f3f2941c6b5f6e097171bd643c697e3d Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Mon, 2 Jul 2018 16:37:03 +0200 Subject: [PATCH] be careful with getSettingsSearchBuildId related to #53445 --- build/gulpfile.vscode.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/build/gulpfile.vscode.js b/build/gulpfile.vscode.js index 88a57cb08e5..526e5e56f5a 100644 --- a/build/gulpfile.vscode.js +++ b/build/gulpfile.vscode.js @@ -265,10 +265,17 @@ function packageTask(platform, arch, opts) { const packageJsonStream = gulp.src(['package.json'], { base: '.' }) .pipe(json({ name, version })); - const settingsSearchBuildId = getSettingsSearchBuildId(packageJson); const date = new Date().toISOString(); + const productJsonUpdate = { commit, date, checksums }; + + try { + productJsonUpdate.settingsSearchBuildId = getSettingsSearchBuildId(packageJson); + } catch (err) { + console.warn(err); + } + const productJsonStream = gulp.src(['product.json'], { base: '.' }) - .pipe(json({ commit, date, checksums, settingsSearchBuildId })); + .pipe(json(productJsonUpdate)); const license = gulp.src(['LICENSES.chromium.html', 'LICENSE.txt', 'ThirdPartyNotices.txt', 'licenses/**'], { base: '.' }); -- GitLab