From 85dcbf72d28603eef00210d4c0aa2ecfc4e1aead Mon Sep 17 00:00:00 2001
From: Alexander <usernamehw@gmail.com>
Date: Wed, 19 Dec 2018 22:09:56 +0300
Subject: [PATCH] Enable strict null checking for Notifications test (#65291)

* Enable strict null checking for Notirications test

* Changing as any to Exclamation mark
---
 src/tsconfig.strictNullChecks.json            |  1 +
 .../test/common/notifications.test.ts         | 20 +++++++++----------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json
index 176bcfdec51..5430b41eb27 100644
--- a/src/tsconfig.strictNullChecks.json
+++ b/src/tsconfig.strictNullChecks.json
@@ -567,6 +567,7 @@
 		"./vs/workbench/common/extensionHostProtocol.ts",
 		"./vs/workbench/common/memento.ts",
 		"./vs/workbench/common/notifications.ts",
+		"./vs/workbench/test/common/notifications.test.ts",
 		"./vs/workbench/common/panel.ts",
 		"./vs/workbench/common/resources.ts",
 		"./vs/workbench/common/theme.ts",
diff --git a/src/vs/workbench/test/common/notifications.test.ts b/src/vs/workbench/test/common/notifications.test.ts
index 282f6d63df5..69b3d465ea3 100644
--- a/src/vs/workbench/test/common/notifications.test.ts
+++ b/src/vs/workbench/test/common/notifications.test.ts
@@ -15,14 +15,14 @@ suite('Notifications', () => {
 
 		// Invalid
 		assert.ok(!NotificationViewItem.create({ severity: Severity.Error, message: '' }));
-		assert.ok(!NotificationViewItem.create({ severity: Severity.Error, message: null }));
+		assert.ok(!NotificationViewItem.create({ severity: Severity.Error, message: null! }));
 
 		// Duplicates
-		let item1 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message' });
-		let item2 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message' });
-		let item3 = NotificationViewItem.create({ severity: Severity.Info, message: 'Info Message' });
-		let item4 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message', source: 'Source' });
-		let item5 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message', actions: { primary: [new Action('id', 'label')] } });
+		let item1 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message' })!;
+		let item2 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message' })!;
+		let item3 = NotificationViewItem.create({ severity: Severity.Info, message: 'Info Message' })!;
+		let item4 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message', source: 'Source' })!;
+		let item5 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message', actions: { primary: [new Action('id', 'label')] } })!;
 
 		assert.equal(item1.equals(item1), true);
 		assert.equal(item2.equals(item2), true);
@@ -102,11 +102,11 @@ suite('Notifications', () => {
 		assert.equal(called, 1);
 
 		// Error with Action
-		let item6 = NotificationViewItem.create({ severity: Severity.Error, message: createErrorWithActions('Hello Error', { actions: [new Action('id', 'label')] }) });
-		assert.equal(item6.actions.primary.length, 1);
+		let item6 = NotificationViewItem.create({ severity: Severity.Error, message: createErrorWithActions('Hello Error', { actions: [new Action('id', 'label')] }) })!;
+		assert.equal(item6.actions.primary!.length, 1);
 
 		// Links
-		let item7 = NotificationViewItem.create({ severity: Severity.Info, message: 'Unable to [Link 1](http://link1.com) open [Link 2](https://link2.com) and [Invalid Link3](ftp://link3.com)' });
+		let item7 = NotificationViewItem.create({ severity: Severity.Info, message: 'Unable to [Link 1](http://link1.com) open [Link 2](https://link2.com) and [Invalid Link3](ftp://link3.com)' })!;
 
 		const links = item7.message.links;
 		assert.equal(links.length, 2);
@@ -124,7 +124,7 @@ suite('Notifications', () => {
 	test('Model', () => {
 		const model = new NotificationsModel();
 
-		let lastEvent: INotificationChangeEvent;
+		let lastEvent!: INotificationChangeEvent;
 		model.onDidNotificationChange(e => {
 			lastEvent = e;
 		});
-- 
GitLab