From 8383d42427fd63497710eeee0e74223aebbdae49 Mon Sep 17 00:00:00 2001
From: Joao Moreno <joao.moreno@microsoft.com>
Date: Thu, 15 Nov 2018 15:03:57 +0100
Subject: [PATCH] fix suggest widget in standalone editor

fixes Microsoft/monaco-editor#1185
fixes Microsoft/monaco-editor#1186

cc @bpasero @ramya-rao-a
---
 .../editor/contrib/suggest/suggestWidget.ts   | 22 +++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/src/vs/editor/contrib/suggest/suggestWidget.ts b/src/vs/editor/contrib/suggest/suggestWidget.ts
index 3dc19b69164..c70849dacd5 100644
--- a/src/vs/editor/contrib/suggest/suggestWidget.ts
+++ b/src/vs/editor/contrib/suggest/suggestWidget.ts
@@ -437,6 +437,9 @@ export class SuggestWidget implements IContentWidget, IListVirtualDelegate<IComp
 	private detailsFocusBorderColor: string;
 	private detailsBorderColor: string;
 
+	private storageServiceAvailable: boolean = true;
+	private expandSuggestionDocs: boolean = false;
+
 	private firstFocusInCurrentList: boolean = false;
 
 	constructor(
@@ -458,6 +461,13 @@ export class SuggestWidget implements IContentWidget, IListVirtualDelegate<IComp
 		this.focusedItem = null;
 		this.storageService = storageService;
 
+		// :facepalm:
+		this.storageService.store('___suggest___', true, StorageScope.GLOBAL);
+		if (!this.storageService.get('___suggest___', StorageScope.GLOBAL)) {
+			this.storageServiceAvailable = false;
+		}
+		this.storageService.remove('___suggest___', StorageScope.GLOBAL);
+
 		this.element = $('.editor-widget.suggest-widget');
 		if (!this.editor.getConfiguration().contribInfo.iconsInSuggestions) {
 			addClass(this.element, 'no-icons');
@@ -1083,11 +1093,19 @@ export class SuggestWidget implements IContentWidget, IListVirtualDelegate<IComp
 	}
 
 	private expandDocsSettingFromStorage(): boolean {
-		return this.storageService.getBoolean('expandSuggestionDocs', StorageScope.GLOBAL, expandSuggestionDocsByDefault);
+		if (this.storageServiceAvailable) {
+			return this.storageService.getBoolean('expandSuggestionDocs', StorageScope.GLOBAL, expandSuggestionDocsByDefault);
+		} else {
+			return this.expandSuggestionDocs;
+		}
 	}
 
 	private updateExpandDocsSetting(value: boolean) {
-		this.storageService.store('expandSuggestionDocs', value, StorageScope.GLOBAL);
+		if (this.storageServiceAvailable) {
+			this.storageService.store('expandSuggestionDocs', value, StorageScope.GLOBAL);
+		} else {
+			this.expandSuggestionDocs = value;
+		}
 	}
 
 	dispose(): void {
-- 
GitLab