From 7a629db3521b6af5dd9c3f15ba7b8abf5a48591e Mon Sep 17 00:00:00 2001 From: isidor Date: Mon, 24 Sep 2018 16:41:53 +0200 Subject: [PATCH] list focus controller do not focus into elements that have tabIndex -1 fixes #52299 --- src/vs/base/browser/ui/list/listWidget.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/base/browser/ui/list/listWidget.ts b/src/vs/base/browser/ui/list/listWidget.ts index e73b78271f4..9bfdc3bc400 100644 --- a/src/vs/base/browser/ui/list/listWidget.ts +++ b/src/vs/base/browser/ui/list/listWidget.ts @@ -358,7 +358,7 @@ class DOMFocusController implements IDisposable { const focusedDomElement = this.view.domElement(focus[0]); const tabIndexElement = focusedDomElement.querySelector('[tabIndex]'); - if (!tabIndexElement || !(tabIndexElement instanceof HTMLElement)) { + if (!tabIndexElement || !(tabIndexElement instanceof HTMLElement) || tabIndexElement.tabIndex === -1) { return; } -- GitLab