From 717f2163c20babb6309bb2c19fbc03a5a5bb890b Mon Sep 17 00:00:00 2001 From: isidor Date: Wed, 8 Nov 2017 10:48:05 +0100 Subject: [PATCH] debug: remove more unused locals #37212 --- .../parts/debug/electron-browser/debugViewer.ts | 15 ++------------- .../parts/debug/electron-browser/debugViews.ts | 4 ++-- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/src/vs/workbench/parts/debug/electron-browser/debugViewer.ts b/src/vs/workbench/parts/debug/electron-browser/debugViewer.ts index 57811167418..e3e0580f11a 100644 --- a/src/vs/workbench/parts/debug/electron-browser/debugViewer.ts +++ b/src/vs/workbench/parts/debug/electron-browser/debugViewer.ts @@ -15,7 +15,7 @@ import { IKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import * as dom from 'vs/base/browser/dom'; import { IMouseEvent, DragMouseEvent } from 'vs/base/browser/mouseEvent'; import { getPathLabel } from 'vs/base/common/labels'; -import { IAction, IActionRunner } from 'vs/base/common/actions'; +import { IAction } from 'vs/base/common/actions'; import { IActionItem, Separator } from 'vs/base/browser/ui/actionbar/actionbar'; import { ITree, IAccessibilityProvider, ContextMenuEvent, IDataSource, IRenderer, DRAG_OVER_REJECT, IDragAndDropData, IDragOverReaction, IActionProvider } from 'vs/base/parts/tree/browser/tree'; import { InputBox, IInputValidationOptions } from 'vs/base/browser/ui/inputbox/inputBox'; @@ -310,8 +310,7 @@ export class CallStackController extends BaseDebugController { export class CallStackActionProvider implements IActionProvider { - // @ts-ignore unused injected service - constructor( @IInstantiationService private instantiationService: IInstantiationService, @debug.IDebugService private debugService: debug.IDebugService) { + constructor( @IInstantiationService private instantiationService: IInstantiationService) { // noop } @@ -886,19 +885,13 @@ export class WatchExpressionsRenderer implements IRenderer { private static WATCH_EXPRESSION_TEMPLATE_ID = 'watchExpression'; private static VARIABLE_TEMPLATE_ID = 'variables'; private toDispose: lifecycle.IDisposable[]; - // @ts-ignore unused property - private actionProvider: WatchExpressionsActionProvider; constructor( - actionProvider: IActionProvider, - // @ts-ignore unused property - private actionRunner: IActionRunner, @debug.IDebugService private debugService: debug.IDebugService, @IContextViewService private contextViewService: IContextViewService, @IThemeService private themeService: IThemeService ) { this.toDispose = []; - this.actionProvider = actionProvider; } public getHeight(tree: ITree, element: any): number { @@ -1135,10 +1128,6 @@ export class BreakpointsRenderer implements IRenderer { private static BREAKPOINT_TEMPLATE_ID = 'breakpoint'; constructor( - // @ts-ignore unused property - private actionProvider: BreakpointsActionProvider, - // @ts-ignore unused property - private actionRunner: IActionRunner, @IWorkspaceContextService private contextService: IWorkspaceContextService, @debug.IDebugService private debugService: debug.IDebugService, @IContextViewService private contextViewService: IContextViewService, diff --git a/src/vs/workbench/parts/debug/electron-browser/debugViews.ts b/src/vs/workbench/parts/debug/electron-browser/debugViews.ts index 5262677d821..77c31005f1c 100644 --- a/src/vs/workbench/parts/debug/electron-browser/debugViews.ts +++ b/src/vs/workbench/parts/debug/electron-browser/debugViews.ts @@ -194,7 +194,7 @@ export class WatchExpressionsView extends ViewsViewletPanel { const actionProvider = new viewer.WatchExpressionsActionProvider(this.instantiationService); this.tree = new Tree(this.treeContainer, { dataSource: new viewer.WatchExpressionsDataSource(), - renderer: this.instantiationService.createInstance(viewer.WatchExpressionsRenderer, actionProvider, this.actionRunner), + renderer: this.instantiationService.createInstance(viewer.WatchExpressionsRenderer), accessibilityProvider: new viewer.WatchExpressionsAccessibilityProvider(), controller: this.instantiationService.createInstance(viewer.WatchExpressionsController, actionProvider, MenuId.DebugWatchContext), dnd: this.instantiationService.createInstance(viewer.WatchExpressionsDragAndDrop) @@ -415,7 +415,7 @@ export class BreakpointsView extends ViewsViewletPanel { this.tree = new Tree(this.treeContainer, { dataSource: new viewer.BreakpointsDataSource(), - renderer: this.instantiationService.createInstance(viewer.BreakpointsRenderer, actionProvider, this.actionRunner), + renderer: this.instantiationService.createInstance(viewer.BreakpointsRenderer), accessibilityProvider: this.instantiationService.createInstance(viewer.BreakpointsAccessibilityProvider), controller, sorter: { -- GitLab