From 6c7b2b34069b7d11f8465fb59a78a38424df025a Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Thu, 21 Oct 2021 18:33:19 +0200 Subject: [PATCH] #135075 Use fake timers --- .../common/userDataSyncStoreService.test.ts | 47 +++++++++++-------- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/src/vs/platform/userDataSync/test/common/userDataSyncStoreService.test.ts b/src/vs/platform/userDataSync/test/common/userDataSyncStoreService.test.ts index af95989d2a2..4790464ce4a 100644 --- a/src/vs/platform/userDataSync/test/common/userDataSyncStoreService.test.ts +++ b/src/vs/platform/userDataSync/test/common/userDataSyncStoreService.test.ts @@ -12,6 +12,7 @@ import { DisposableStore } from 'vs/base/common/lifecycle'; import { isWeb } from 'vs/base/common/platform'; import { ConfigurationSyncStore } from 'vs/base/common/product'; import { URI } from 'vs/base/common/uri'; +import { runWithFakedTimers } from 'vs/base/test/common/timeTravelScheduler'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IEnvironmentService } from 'vs/platform/environment/common/environment'; import { IFileService } from 'vs/platform/files/common/files'; @@ -395,19 +396,22 @@ suite('UserDataSyncStoreService', () => { }); test('test donotMakeRequestsUntil is reset after retry time is finished', async () => { - const client = disposableStore.add(new UserDataSyncClient(new UserDataSyncTestServer(1, 0.25))); - await client.setUp(); - const testObject = client.instantiationService.get(IUserDataSyncStoreService); + return runWithFakedTimers({ useFakeTimers: true }, async () => { + const client = disposableStore.add(new UserDataSyncClient(new UserDataSyncTestServer(1, 0.25))); + await client.setUp(); + const testObject = client.instantiationService.get(IUserDataSyncStoreService); - await testObject.manifest(null); - try { await testObject.manifest(null); - } catch (e) { } + try { + await testObject.manifest(null); + assert.fail('should fail'); + } catch (e) { } - const promise = Event.toPromise(testObject.onDidChangeDonotMakeRequestsUntil); - await timeout(300); - await promise; - assert.ok(!testObject.donotMakeRequestsUntil); + const promise = Event.toPromise(testObject.onDidChangeDonotMakeRequestsUntil); + await timeout(300); + await promise; + assert.ok(!testObject.donotMakeRequestsUntil); + }); }); test('test donotMakeRequestsUntil is retrieved', async () => { @@ -425,18 +429,21 @@ suite('UserDataSyncStoreService', () => { }); test('test donotMakeRequestsUntil is checked and reset after retreived', async () => { - const client = disposableStore.add(new UserDataSyncClient(new UserDataSyncTestServer(1, 0.25))); - await client.setUp(); - const testObject = client.instantiationService.get(IUserDataSyncStoreService); + return runWithFakedTimers({ useFakeTimers: true }, async () => { + const client = disposableStore.add(new UserDataSyncClient(new UserDataSyncTestServer(1, 0.25))); + await client.setUp(); + const testObject = client.instantiationService.get(IUserDataSyncStoreService); - await testObject.manifest(null); - try { await testObject.manifest(null); - } catch (e) { } - - await timeout(300); - const target = disposableStore.add(client.instantiationService.createInstance(UserDataSyncStoreService)); - assert.ok(!target.donotMakeRequestsUntil); + try { + await testObject.manifest(null); + assert.fail('should fail'); + } catch (e) { } + + await timeout(300); + const target = disposableStore.add(client.instantiationService.createInstance(UserDataSyncStoreService)); + assert.ok(!target.donotMakeRequestsUntil); + }); }); test('test read resource request handles 304', async () => { -- GitLab