add tslint duplicateImportsRule

build/lib/tslint/duplicateImportsRule.js

+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+"use strict";
+var __extends = (this && this.__extends) || function (d, b) {
+    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
+    function __() { this.constructor = d; }
+    d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
+};
+var path_1 = require('path');
+var Lint = require('tslint/lib/lint');
+var Rule = (function (_super) {
+    __extends(Rule, _super);
+    function Rule() {
+        _super.apply(this, arguments);
+    }
+    Rule.prototype.apply = function (sourceFile) {
+        return this.applyWithWalker(new ImportPatterns(sourceFile, this.getOptions()));
+    };
+    return Rule;
+}(Lint.Rules.AbstractRule));
+exports.Rule = Rule;
+var ImportPatterns = (function (_super) {
+    __extends(ImportPatterns, _super);
+    function ImportPatterns(file, opts) {
+        _super.call(this, file, opts);
+        this.imports = Object.create(null);
+    }
+    ImportPatterns.prototype.visitImportDeclaration = function (node) {
+        var path = node.moduleSpecifier.getText();
+        // remove quotes
+        path = path.slice(1, -1);
+        if (path[0] === '.') {
+            path = path_1.join(path_1.dirname(node.getSourceFile().fileName), path);
+        }
+        if (this.imports[path]) {
+            this.addFailure(this.createFailure(node.getStart(), node.getWidth(), "Duplicate imports for '" + path + "'."));
+        }
+        this.imports[path] = true;
+    };
+    return ImportPatterns;
+}(Lint.RuleWalker));

build/lib/tslint/duplicateImportsRule.ts

+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as ts from 'typescript';
+import { join, dirname } from 'path';
+import * as Lint from 'tslint/lib/lint';
+
+export class Rule extends Lint.Rules.AbstractRule {
+	public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
+		return this.applyWithWalker(new ImportPatterns(sourceFile, this.getOptions()));
+	}
+}
+
+class ImportPatterns extends Lint.RuleWalker {
+
+	private imports: { [path: string]: boolean; } = Object.create(null);
+
+	constructor(file: ts.SourceFile, opts: Lint.IOptions) {
+		super(file, opts);
+	}
+
+	protected visitImportDeclaration(node: ts.ImportDeclaration): void {
+		let path = node.moduleSpecifier.getText();
+
+		// remove quotes
+		path = path.slice(1, -1);
+
+		if (path[0] === '.') {
+			path = join(dirname(node.getSourceFile().fileName), path);
+		}
+
+		if (this.imports[path]) {
+			this.addFailure(this.createFailure(node.getStart(), node.getWidth(), `Duplicate imports for '${path}'.`));
+		}
+
+		this.imports[path] = true;
+	}
+}

build/lib/tslint/layeringRule.js

@@ -49,6 +49,8 @@ var LayeringRule = (function (_super) {
     }
     LayeringRule.prototype.visitImportDeclaration = function (node) {
         var path = node.moduleSpecifier.getText();
+        // remove quotes
+        path = path.slice(1, -1);
         if (path[0] === '.') {
             path = path_1.join(path_1.dirname(node.getSourceFile().fileName), path);
         }

build/lib/tslint/layeringRule.ts

@@ -52,8 +52,11 @@ class LayeringRule extends Lint.RuleWalker {
 	}
 
 	protected visitImportDeclaration(node: ts.ImportDeclaration): void {
-
 		let path = node.moduleSpecifier.getText();
+
+		// remove quotes
+		path = path.slice(1, -1);
+
 		if (path[0] === '.') {
 			path = join(dirname(node.getSourceFile().fileName), path);
 		}

build/lib/tslint/noUnexternalizedStringsRule.js

@@ -109,8 +109,8 @@ var NoUnexternalizedStringsRuleWalker = (function (_super) {
                 for (var i = 0; i < keyArg.properties.length; i++) {
                     var property = keyArg.properties[i];
                     if (isPropertyAssignment(property)) {
-                        var name = property.name.getText();
-                        if (name === 'key') {
+                        var name_1 = property.name.getText();
+                        if (name_1 === 'key') {
                             var initializer = property.initializer;
                             if (isStringLiteral(initializer)) {
                                 this.recordKey(initializer, this.messageIndex ? callInfo.callExpression.arguments[this.messageIndex] : undefined);

build/lib/util.js

@@ -98,15 +98,15 @@ function skipDirectories() {
 }
 exports.skipDirectories = skipDirectories;
 function cleanNodeModule(name, excludes, includes) {
-    var glob = function (path) { return '**/node_modules/' + name + (path ? '/' + path : ''); };
+    var toGlob = function (path) { return '**/node_modules/' + name + (path ? '/' + path : ''); };
     var negate = function (str) { return '!' + str; };
-    var allFilter = _filter(glob('**'), { restore: true });
-    var globs = [glob('**')].concat(excludes.map(_.compose(negate, glob)));
+    var allFilter = _filter(toGlob('**'), { restore: true });
+    var globs = [toGlob('**')].concat(excludes.map(_.compose(negate, toGlob)));
     var input = es.through();
     var nodeModuleInput = input.pipe(allFilter);
     var output = nodeModuleInput.pipe(_filter(globs));
     if (includes) {
-        var includeGlobs = includes.map(glob);
+        var includeGlobs = includes.map(toGlob);
         output = es.merge(output, nodeModuleInput.pipe(_filter(includeGlobs)));
     }
     output = output.pipe(allFilter.restore);