From 67e52a29379562e3a7233fd1a9fa0aafbd82a4c3 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Fri, 4 Jan 2019 10:29:34 -0800 Subject: [PATCH] Strict null check browser/editor --- src/tsconfig.strictNullChecks.json | 2 ++ src/vs/workbench/browser/editor.ts | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json index fb9bd9626fb..9203b27d84a 100644 --- a/src/tsconfig.strictNullChecks.json +++ b/src/tsconfig.strictNullChecks.json @@ -521,6 +521,7 @@ "./vs/workbench/browser/actions/toggleTabsVisibility.ts", "./vs/workbench/browser/actions/toggleZenMode.ts", "./vs/workbench/browser/composite.ts", + "./vs/workbench/browser/editor.ts", "./vs/workbench/browser/panel.ts", "./vs/workbench/browser/part.ts", "./vs/workbench/browser/parts/editor/baseEditor.ts", @@ -699,6 +700,7 @@ "./vs/workbench/parts/welcome/page/electron-browser/welcomePage.contribution.ts", "./vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts", "./vs/workbench/parts/welcome/walkThrough/electron-browser/editor/editorWalkThrough.ts", + "./vs/workbench/parts/welcome/walkThrough/electron-browser/walkThrough.contribution.ts", "./vs/workbench/parts/welcome/walkThrough/electron-browser/walkThroughActions.ts", "./vs/workbench/parts/welcome/walkThrough/electron-browser/walkThroughPart.ts", "./vs/workbench/parts/welcome/walkThrough/node/walkThroughContentProvider.ts", diff --git a/src/vs/workbench/browser/editor.ts b/src/vs/workbench/browser/editor.ts index cc0de2fd029..94b73d112ef 100644 --- a/src/vs/workbench/browser/editor.ts +++ b/src/vs/workbench/browser/editor.ts @@ -36,12 +36,12 @@ export interface IEditorRegistry { /** * Returns the editor descriptor for the given input or null if none. */ - getEditor(input: EditorInput): IEditorDescriptor; + getEditor(input: EditorInput): IEditorDescriptor | null; /** * Returns the editor descriptor for the given identifier or null if none. */ - getEditorById(editorId: string): IEditorDescriptor; + getEditorById(editorId: string): IEditorDescriptor | null; /** * Returns an array of registered editors known to the platform. @@ -103,7 +103,7 @@ class EditorRegistry implements IEditorRegistry { this.editors.push(descriptor); } - getEditor(input: EditorInput): EditorDescriptor { + getEditor(input: EditorInput): EditorDescriptor | null { const findEditorDescriptors = (input: EditorInput, byInstanceOf?: boolean): EditorDescriptor[] => { const matchingDescriptors: EditorDescriptor[] = []; @@ -154,7 +154,7 @@ class EditorRegistry implements IEditorRegistry { return null; } - getEditorById(editorId: string): EditorDescriptor { + getEditorById(editorId: string): EditorDescriptor | null { for (const editor of this.editors) { if (editor.getId() === editorId) { return editor; -- GitLab