From 4b92f83fcd30c89f9aaa083162aa894f25ba84f0 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Mon, 7 Jan 2019 18:11:28 -0800 Subject: [PATCH] Fix bad progress service strict null check conversion These values are really supposed to be undefined --- src/vs/workbench/services/progress/browser/progressService.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/services/progress/browser/progressService.ts b/src/vs/workbench/services/progress/browser/progressService.ts index 50408361896..972d8efe670 100644 --- a/src/vs/workbench/services/progress/browser/progressService.ts +++ b/src/vs/workbench/services/progress/browser/progressService.ts @@ -128,8 +128,8 @@ export class ScopedProgressService extends ScopedService implements IProgressSer show(infinite: boolean, delay?: number): IProgressRunner; show(total: number, delay?: number): IProgressRunner; show(infiniteOrTotal: boolean | number, delay?: number): IProgressRunner { - let infinite: boolean = false; - let total: number = 0; + let infinite: boolean | undefined; + let total: number | undefined; // Sort out Arguments if (typeof infiniteOrTotal === 'boolean') { -- GitLab