未验证 提交 2e53042c 编写于 作者: S Sandeep Somavarapu 提交者: GitHub

Fix-73341 Installing extension from extension page "Install" b… (#74795)

Fix-73341 Installing extension from extension page "Install" button keeps the notification baloon in bottom right
...@@ -20,7 +20,6 @@ import { getGalleryExtensionTelemetryData, getLocalExtensionTelemetryData, areSa ...@@ -20,7 +20,6 @@ import { getGalleryExtensionTelemetryData, getLocalExtensionTelemetryData, areSa
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { IWindowService } from 'vs/platform/windows/common/windows'; import { IWindowService } from 'vs/platform/windows/common/windows';
import Severity from 'vs/base/common/severity';
import { URI } from 'vs/base/common/uri'; import { URI } from 'vs/base/common/uri';
import { IExtension, ExtensionState, IExtensionsWorkbenchService, AutoUpdateConfigurationKey, AutoCheckUpdatesConfigurationKey } from 'vs/workbench/contrib/extensions/common/extensions'; import { IExtension, ExtensionState, IExtensionsWorkbenchService, AutoUpdateConfigurationKey, AutoCheckUpdatesConfigurationKey } from 'vs/workbench/contrib/extensions/common/extensions';
import { IEditorService, SIDE_GROUP, ACTIVE_GROUP } from 'vs/workbench/services/editor/common/editorService'; import { IEditorService, SIDE_GROUP, ACTIVE_GROUP } from 'vs/workbench/services/editor/common/editorService';
...@@ -1043,7 +1042,6 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension ...@@ -1043,7 +1042,6 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension
return this.windowService.focusWindow() return this.windowService.focusWindow()
.then(() => this.open(extension)); .then(() => this.open(extension));
} }
return this.queryGallery({ names: [extensionId], source: 'uri' }, CancellationToken.None).then(result => { return this.queryGallery({ names: [extensionId], source: 'uri' }, CancellationToken.None).then(result => {
if (result.total < 1) { if (result.total < 1) {
return Promise.resolve(null); return Promise.resolve(null);
...@@ -1052,17 +1050,7 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension ...@@ -1052,17 +1050,7 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension
const extension = result.firstPage[0]; const extension = result.firstPage[0];
return this.windowService.focusWindow().then(() => { return this.windowService.focusWindow().then(() => {
return this.open(extension).then(() => { return this.open(extension);
this.notificationService.prompt(
Severity.Info,
nls.localize('installConfirmation', "Would you like to install the '{0}' extension?", extension.displayName, extension.publisher),
[{
label: nls.localize('install', "Install"),
run: () => this.install(extension).then(undefined, error => this.onError(error))
}],
{ sticky: true }
);
});
}); });
}); });
}).then(undefined, error => this.onError(error)); }).then(undefined, error => this.onError(error));
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册