From 11d8b59217fcc8ef277e423a7f68233479d21854 Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 26 Oct 2021 11:08:22 -0700 Subject: [PATCH] fix #135810 --- .../workbench/contrib/terminal/browser/terminalService.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalService.ts b/src/vs/workbench/contrib/terminal/browser/terminalService.ts index fa3f5ff7bb8..f001095e567 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalService.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalService.ts @@ -293,7 +293,11 @@ export class TerminalService implements ITerminalService { if (instanceToDetach) { const persistentProcessId = instanceToDetach?.persistentProcessId; if (persistentProcessId && !instanceToDetach.shellLaunchConfig.isFeatureTerminal && !instanceToDetach.shellLaunchConfig.customPtyImplementation) { - this._terminalEditorService.detachInstance(instanceToDetach); + if (instanceToDetach.target === TerminalLocation.Editor) { + this._terminalEditorService.detachInstance(instanceToDetach); + } else { + this._terminalGroupService.getGroupForInstance(instanceToDetach)?.removeInstance(instanceToDetach); + } await instanceToDetach.detachFromProcess(); await this._primaryOffProcessTerminalService?.acceptDetachInstanceReply(e.requestId, persistentProcessId); } else { -- GitLab