From 1005872bf14196a255121356db0748bf90e95d7d Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Thu, 12 Jul 2018 09:48:59 +0200 Subject: [PATCH] fix #54057 --- src/vs/editor/contrib/suggest/suggest.ts | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/vs/editor/contrib/suggest/suggest.ts b/src/vs/editor/contrib/suggest/suggest.ts index 9bfe478497b..0df5abe1e5e 100644 --- a/src/vs/editor/contrib/suggest/suggest.ts +++ b/src/vs/editor/contrib/suggest/suggest.ts @@ -236,10 +236,16 @@ interface SuggestController extends IEditorContribution { triggerSuggest(onlyFrom?: ISuggestSupport[]): void; } -let _suggestions: ISuggestion[]; + let _provider = new class implements ISuggestSupport { + + onlyOnceSuggestions: ISuggestion[] = []; + provideCompletionItems(): ISuggestResult { - return _suggestions && { suggestions: _suggestions }; + let suggestions = this.onlyOnceSuggestions.slice(0); + let result = { suggestions }; + this.onlyOnceSuggestions.length = 0; + return result; } }; @@ -247,8 +253,7 @@ SuggestRegistry.register('*', _provider); export function showSimpleSuggestions(editor: ICodeEditor, suggestions: ISuggestion[]) { setTimeout(() => { - _suggestions = suggestions; + _provider.onlyOnceSuggestions.push(...suggestions); editor.getContribution('editor.contrib.suggestController').triggerSuggest([_provider]); - _suggestions = undefined; }, 0); } -- GitLab