From 09ee89ca874958b04c695691c832970c317c5175 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Fri, 3 Jan 2020 08:14:23 +0100 Subject: [PATCH] remove more unused tslint directives --- extensions/typescript-language-features/src/extension.ts | 1 - src/vs/editor/contrib/find/findWidget.ts | 1 - src/vs/platform/contextkey/test/common/contextkey.test.ts | 2 -- .../contrib/codeActions/common/codeActions.contribution.ts | 1 - .../contrib/codeEditor/browser/find/simpleFindWidget.ts | 1 - src/vs/workbench/contrib/search/browser/searchWidget.ts | 1 - .../test/electron-browser/api/extHostDiagnostics.test.ts | 1 - .../electron-browser/api/mainThreadDocumentsAndEditors.test.ts | 2 -- 8 files changed, 10 deletions(-) diff --git a/extensions/typescript-language-features/src/extension.ts b/extensions/typescript-language-features/src/extension.ts index ffa61f231f1..a7493570f1b 100644 --- a/extensions/typescript-language-features/src/extension.ts +++ b/extensions/typescript-language-features/src/extension.ts @@ -99,7 +99,6 @@ function lazilyActivateClient( if (!hasActivated && isSupportedDocument(supportedLanguage, textDocument)) { hasActivated = true; // Force activation - // tslint:disable-next-line:no-unused-expression void lazyClientHost.value; disposables.push(new ManagedFileContextManager(resource => { diff --git a/src/vs/editor/contrib/find/findWidget.ts b/src/vs/editor/contrib/find/findWidget.ts index d2f904129a9..8cf2da8896c 100644 --- a/src/vs/editor/contrib/find/findWidget.ts +++ b/src/vs/editor/contrib/find/findWidget.ts @@ -908,7 +908,6 @@ export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas return null; } try { - /* tslint:disable-next-line:no-unused-expression */ new RegExp(value); return null; } catch (e) { diff --git a/src/vs/platform/contextkey/test/common/contextkey.test.ts b/src/vs/platform/contextkey/test/common/contextkey.test.ts index c1748e10ea0..72929eff428 100644 --- a/src/vs/platform/contextkey/test/common/contextkey.test.ts +++ b/src/vs/platform/contextkey/test/common/contextkey.test.ts @@ -57,7 +57,6 @@ suite('ContextKeyExpr', () => { }); test('evaluate', () => { - /* tslint:disable:triple-equals */ let context = createContext({ 'a': true, 'b': false, @@ -94,7 +93,6 @@ suite('ContextKeyExpr', () => { testExpression('a && b', true && false); testExpression('a && !b && c == 5', true && !false && '5' === '5'); testExpression('d =~ /e.*/', false); - /* tslint:enable:triple-equals */ // precedence test: false && true || true === true because && is evaluated first testExpression('b && a || a', true); diff --git a/src/vs/workbench/contrib/codeActions/common/codeActions.contribution.ts b/src/vs/workbench/contrib/codeActions/common/codeActions.contribution.ts index 94cab6e33d5..ddf83c61dc7 100644 --- a/src/vs/workbench/contrib/codeActions/common/codeActions.contribution.ts +++ b/src/vs/workbench/contrib/codeActions/common/codeActions.contribution.ts @@ -21,7 +21,6 @@ class WorkbenchContribution { constructor( @IKeybindingService keybindingsService: IKeybindingService, ) { - // tslint:disable-next-line: no-unused-expression new CodeActionWorkbenchContribution(codeActionsExtensionPoint, keybindingsService); } } diff --git a/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.ts b/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.ts index fbbf29cc24e..5e58e2ef155 100644 --- a/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.ts +++ b/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.ts @@ -54,7 +54,6 @@ export abstract class SimpleFindWidget extends Widget { return null; } try { - /* tslint:disable-next-line:no-unused-expression */ new RegExp(value); return null; } catch (e) { diff --git a/src/vs/workbench/contrib/search/browser/searchWidget.ts b/src/vs/workbench/contrib/search/browser/searchWidget.ts index 21c0ecebd20..77defd9110c 100644 --- a/src/vs/workbench/contrib/search/browser/searchWidget.ts +++ b/src/vs/workbench/contrib/search/browser/searchWidget.ts @@ -439,7 +439,6 @@ export class SearchWidget extends Widget { return null; } try { - // tslint:disable-next-line: no-unused-expression new RegExp(value, 'u'); } catch (e) { return { content: e.message }; diff --git a/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts b/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts index 6a1852d8990..1a3f95ea4c3 100644 --- a/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts +++ b/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts @@ -33,7 +33,6 @@ suite('ExtHostDiagnostics', () => { assert.throws(() => collection.name); assert.throws(() => collection.clear()); assert.throws(() => collection.delete(URI.parse('aa:bb'))); - // tslint:disable-next-line:semicolon assert.throws(() => collection.forEach(() => { })); assert.throws(() => collection.get(URI.parse('aa:bb'))); assert.throws(() => collection.has(URI.parse('aa:bb'))); diff --git a/src/vs/workbench/test/electron-browser/api/mainThreadDocumentsAndEditors.test.ts b/src/vs/workbench/test/electron-browser/api/mainThreadDocumentsAndEditors.test.ts index 0703fb2ac59..78c73141ae0 100644 --- a/src/vs/workbench/test/electron-browser/api/mainThreadDocumentsAndEditors.test.ts +++ b/src/vs/workbench/test/electron-browser/api/mainThreadDocumentsAndEditors.test.ts @@ -61,7 +61,6 @@ suite('MainThreadDocumentsAndEditors', () => { onAfterOperation = Event.None; }; - /* tslint:disable */ new MainThreadDocumentsAndEditors( SingleProxyRPCProtocol(new class extends mock() { $acceptDocumentsAndEditorsDelta(delta: IDocumentsAndEditorsDelta) { deltas.push(delta); } @@ -86,7 +85,6 @@ suite('MainThreadDocumentsAndEditors', () => { }, TestEnvironmentService ); - /* tslint:enable */ }); -- GitLab