From 926911700eb4c891d65124e95ddf4932d12d91a3 Mon Sep 17 00:00:00 2001 From: ScienJus Date: Tue, 6 Nov 2018 18:32:02 +0800 Subject: [PATCH] Fix logs with missing variables (#1884) --- .../skywalking/oap/server/core/cache/CacheUpdateTimer.java | 2 +- .../core/register/service/ServiceInstanceInventoryRegister.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java index 3d3cbdfff2..3f06ecc1ef 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java @@ -64,7 +64,7 @@ public enum CacheUpdateTimer { cache.setMappingServiceId(serviceInventory.getMappingServiceId()); cache.setMappingLastUpdateTime(serviceInventory.getMappingLastUpdateTime()); } else { - logger.warn("Unable to found the id of {} in service inventory cache."); + logger.warn("Unable to found the id of {} in service inventory cache.", serviceInventory.getSequence()); } }); } diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInstanceInventoryRegister.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInstanceInventoryRegister.java index 8bb47a2100..c6b0e5ec80 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInstanceInventoryRegister.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInstanceInventoryRegister.java @@ -107,7 +107,7 @@ public class ServiceInstanceInventoryRegister implements IServiceInstanceInvento serviceInstanceInventory.setHeartbeatTime(heartBeatTime); InventoryProcess.INSTANCE.in(serviceInstanceInventory); } else { - logger.warn("Service instance {} heartbeat, but not found in storage."); + logger.warn("Service instance {} heartbeat, but not found in storage.", serviceInstanceId); } } } -- GitLab