Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
润土的好友猹
SkyWalking
提交
573c3359
S
SkyWalking
项目概览
润土的好友猹
/
SkyWalking
与 Fork 源项目一致
Fork自
apache / SkyWalking
通知
9
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
SkyWalking
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
573c3359
编写于
4月 03, 2021
作者:
D
Darcy
提交者:
GitHub
4月 03, 2021
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix Agent Plugin "asynchttpclient" not record the status code of the … (#6665)
上级
0dd9cc1e
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
9 addition
and
1 deletion
+9
-1
CHANGES.md
CHANGES.md
+1
-0
apm-sniffer/apm-sdk-plugin/asynchttpclient-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asynchttpclient/v2/AsyncHandlerWrapper.java
...ng/apm/plugin/asynchttpclient/v2/AsyncHandlerWrapper.java
+7
-1
test/plugin/scenarios/asynchttpclient-scenario/config/expectedData.yaml
...enarios/asynchttpclient-scenario/config/expectedData.yaml
+1
-0
未找到文件。
CHANGES.md
浏览文件 @
573c3359
...
...
@@ -29,6 +29,7 @@ Release Notes.
*
Fix bug that springmvn-annotation-4.x-plugin, witness class does not exist in some versions.
*
Add Redis command parameters to 'db.statement' field on Lettuce span UI for displaying more info
*
Fix NullPointerException with
`ReactiveRequestHolder.getHeaders`
.
*
Fix bug that asynchttpclient plugin does not record the response status code
#### OAP-Backend
*
Allow user-defined
`JAVA_OPTS`
in the startup script.
...
...
apm-sniffer/apm-sdk-plugin/asynchttpclient-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asynchttpclient/v2/AsyncHandlerWrapper.java
浏览文件 @
573c3359
...
...
@@ -22,6 +22,7 @@ import io.netty.handler.codec.http.HttpHeaders;
import
java.net.InetSocketAddress
;
import
java.util.List
;
import
javax.net.ssl.SSLSession
;
import
org.apache.skywalking.apm.agent.core.context.tag.Tags
;
import
org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan
;
import
org.apache.skywalking.apm.agent.core.logging.api.ILog
;
import
org.apache.skywalking.apm.agent.core.logging.api.LogManager
;
...
...
@@ -40,7 +41,7 @@ public class AsyncHandlerWrapper implements AsyncHandler {
private
final
AsyncHandler
userAsyncHandler
;
private
final
AbstractSpan
asyncSpan
;
private
static
ILog
LOGGER
=
LogManager
.
getLogger
(
AsyncHandlerWrapper
.
class
);
private
static
final
ILog
LOGGER
=
LogManager
.
getLogger
(
AsyncHandlerWrapper
.
class
);
public
AsyncHandlerWrapper
(
AsyncHandler
asyncHandler
,
AbstractSpan
span
)
{
this
.
userAsyncHandler
=
asyncHandler
==
null
?
new
AsyncCompletionHandlerBase
()
:
asyncHandler
;
...
...
@@ -49,6 +50,11 @@ public class AsyncHandlerWrapper implements AsyncHandler {
@Override
public
State
onStatusReceived
(
final
HttpResponseStatus
httpResponseStatus
)
throws
Exception
{
int
statusCode
=
httpResponseStatus
.
getStatusCode
();
Tags
.
STATUS_CODE
.
set
(
asyncSpan
,
String
.
valueOf
(
statusCode
));
if
(
statusCode
>=
400
)
{
asyncSpan
.
errorOccurred
();
}
return
userAsyncHandler
.
onStatusReceived
(
httpResponseStatus
);
}
...
...
test/plugin/scenarios/asynchttpclient-scenario/config/expectedData.yaml
浏览文件 @
573c3359
...
...
@@ -34,6 +34,7 @@ segmentItems:
tags
:
-
{
key
:
http.method
,
value
:
GET
}
-
{
key
:
url
,
value
:
'
http://localhost:8080/asynchttpclient/back'
}
-
{
key
:
status_code
,
value
:
'
200'
}
-
operationName
:
/asynchttpclient/case
operationId
:
0
parentSpanId
:
-1
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录