From 47df503badbf6e7e86f6f67916012918ec4b5676 Mon Sep 17 00:00:00 2001 From: wusheng Date: Sun, 19 Feb 2017 08:50:38 +0800 Subject: [PATCH] Refactor TracerContext.finish() --- .../main/java/com/a/eye/skywalking/trace/TraceSegment.java | 5 ++++- .../java/com/a/eye/skywalking/context/TracerContext.java | 6 ++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/skywalking-commons/skywalking-trace/src/main/java/com/a/eye/skywalking/trace/TraceSegment.java b/skywalking-commons/skywalking-trace/src/main/java/com/a/eye/skywalking/trace/TraceSegment.java index 1abf1d8406..5d9d81b150 100644 --- a/skywalking-commons/skywalking-trace/src/main/java/com/a/eye/skywalking/trace/TraceSegment.java +++ b/skywalking-commons/skywalking-trace/src/main/java/com/a/eye/skywalking/trace/TraceSegment.java @@ -93,9 +93,12 @@ public class TraceSegment { /** * Finish this {@link TraceSegment}. + * + * return this, for chaining */ - public void finish(){ + public TraceSegment finish(){ this.endTime = System.currentTimeMillis(); + return this; } public String getTraceSegmentId() { diff --git a/skywalking-sniffer/skywalking-api/src/main/java/com/a/eye/skywalking/context/TracerContext.java b/skywalking-sniffer/skywalking-api/src/main/java/com/a/eye/skywalking/context/TracerContext.java index 446b5211a7..c34d69592e 100644 --- a/skywalking-sniffer/skywalking-api/src/main/java/com/a/eye/skywalking/context/TracerContext.java +++ b/skywalking-sniffer/skywalking-api/src/main/java/com/a/eye/skywalking/context/TracerContext.java @@ -78,13 +78,15 @@ public final class TracerContext { } if (activeSpanStack.isEmpty()) { - segment.finish(); this.finish(); } } + /** + * Finish this context, and notify all {@link TracerContextListener}s, managed by {@link ListenerManager} + */ private void finish() { - ListenerManager.notifyFinish(segment); + ListenerManager.notifyFinish(segment.finish()); } /** -- GitLab