diff --git a/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/Channels.java b/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/Channels.java index 26c7ab03c66d8ea7726f71aa8cf697a7b30bd198..b9ad4fd772ec585a820ab382af2b96b59800fabf 100644 --- a/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/Channels.java +++ b/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/Channels.java @@ -27,7 +27,7 @@ import org.apache.skywalking.apm.commons.datacarrier.partition.IDataPartitioner; public class Channels { private final QueueBuffer[] bufferChannels; private IDataPartitioner dataPartitioner; - private BufferStrategy strategy; + private final BufferStrategy strategy; private final long size; public Channels(int channelSize, int bufferSize, IDataPartitioner partitioner, BufferStrategy strategy) { @@ -36,12 +36,13 @@ public class Channels { bufferChannels = new QueueBuffer[channelSize]; for (int i = 0; i < channelSize; i++) { if (BufferStrategy.BLOCKING.equals(strategy)) { - bufferChannels[i] = new ArrayBlockingQueueBuffer(bufferSize, strategy); + bufferChannels[i] = new ArrayBlockingQueueBuffer<>(bufferSize, strategy); } else { - bufferChannels[i] = new Buffer(bufferSize, strategy); + bufferChannels[i] = new Buffer<>(bufferSize, strategy); } } - size = channelSize * bufferSize; + // noinspection PointlessArithmeticExpression + size = 1L * channelSize * bufferSize; // it's not pointless, it prevents numeric overflow before assigning an integer to a long } public boolean save(T data) {