From 70e6c203abb98a3f92fdf685eb084c895aabcc39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BD=AD=E5=8B=87=E5=8D=87=20pengys?= <8082209@qq.com> Date: Tue, 12 Mar 2019 22:52:38 +0800 Subject: [PATCH] Shutdown the OAP server when catch any exception. (#2352) --- .../skywalking/oap/server/starter/OAPServerStartUp.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/OAPServerStartUp.java b/oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/OAPServerStartUp.java index 8c16043b6c..4f2f316202 100644 --- a/oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/OAPServerStartUp.java +++ b/oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/OAPServerStartUp.java @@ -20,7 +20,7 @@ package org.apache.skywalking.oap.server.starter; import org.apache.skywalking.oap.server.core.RunningMode; import org.apache.skywalking.oap.server.library.module.*; -import org.apache.skywalking.oap.server.starter.config.*; +import org.apache.skywalking.oap.server.starter.config.ApplicationConfigLoader; import org.apache.skywalking.oap.server.telemetry.TelemetryModule; import org.apache.skywalking.oap.server.telemetry.api.*; import org.slf4j.*; @@ -45,14 +45,14 @@ public class OAPServerStartUp { manager.find(TelemetryModule.NAME).provider().getService(MetricCreator.class).createGauge("uptime", "oap server start up time", MetricTag.EMPTY_KEY, MetricTag.EMPTY_VALUE) // Set uptime to second - .setValue(System.currentTimeMillis() / 1000); + .setValue(System.currentTimeMillis() / 1000d); if (RunningMode.isInitMode()) { logger.info("OAP starts up in init mode successfully, exit now..."); System.exit(0); } - } catch (ConfigFileNotFoundException | ModuleNotFoundException | ProviderNotFoundException | ServiceNotProvidedException | ModuleConfigException | ModuleStartException e) { - logger.error(e.getMessage(), e); + } catch (Throwable t) { + logger.error(t.getMessage(), t); System.exit(1); } } -- GitLab