From f7bd31fe89320bf8fe09009c45e6d61c0da573a3 Mon Sep 17 00:00:00 2001 From: Yanjun Shi Date: Thu, 22 Aug 2019 15:39:07 +0800 Subject: [PATCH] Fix search plugin result inaccurate (#109) * fix plugin search for jcli * Remove result when not found plugin --- app/cmd/plugin_search.go | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/app/cmd/plugin_search.go b/app/cmd/plugin_search.go index 9816f49..0c0a2ff 100644 --- a/app/cmd/plugin_search.go +++ b/app/cmd/plugin_search.go @@ -62,7 +62,7 @@ func searchPlugins(plugins *client.AvailablePluginList, keyword string) []client result := make([]client.AvailablePlugin, 0) for _, plugin := range plugins.Data { - if strings.Contains(plugin.Name, keyword) { + if strings.Contains(plugin.Name, strings.ToLower(keyword)) { result = append(result, plugin) } } @@ -72,13 +72,16 @@ func searchPlugins(plugins *client.AvailablePluginList, keyword string) []client func (o *PluginSearchOption) Output(obj interface{}) (data []byte, err error) { if data, err = o.OutputOption.Output(obj); err != nil { pluginList := obj.([]client.AvailablePlugin) - table := util.CreateTable(os.Stdout) - table.AddRow("number", "name", "installed", "title") - for i, plugin := range pluginList { - table.AddRow(fmt.Sprintf("%d", i), plugin.Name, - fmt.Sprintf("%v", plugin.Installed), plugin.Title) + if len(pluginList) != 0 { + table := util.CreateTable(os.Stdout) + table.AddRow("number", "name", "installed", "title") + + for i, plugin := range pluginList { + table.AddRow(fmt.Sprintf("%d", i), plugin.Name, + fmt.Sprintf("%v", plugin.Installed), plugin.Title) + } + table.Render() } - table.Render() err = nil data = []byte{} } -- GitLab