From fd754eaa08a13f548b18e4e8e720dee4a4a5a605 Mon Sep 17 00:00:00 2001
From: shenglian zhou <shenglian_zhou@163.com>
Date: Sun, 25 Jun 2023 11:31:33 +0800
Subject: [PATCH] fix: udfd can not connect to taosd since authentification
 failure

---
 include/libs/function/tudf.h             |  6 ++++++
 source/dnode/mnode/impl/src/mndProfile.c | 10 +++++++++-
 source/libs/function/src/tudf.c          | 12 ++++++++++++
 3 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/include/libs/function/tudf.h b/include/libs/function/tudf.h
index b71d50d43c..6b15833917 100644
--- a/include/libs/function/tudf.h
+++ b/include/libs/function/tudf.h
@@ -111,6 +111,12 @@ int32_t udfStartUdfd(int32_t startDnodeId);
  */
 int32_t udfStopUdfd();
 
+/**
+ * get udfd pid
+ *
+ */
+ int32_t udfGetUdfdPid(int32_t* pUdfdPid);
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/source/dnode/mnode/impl/src/mndProfile.c b/source/dnode/mnode/impl/src/mndProfile.c
index 0bfab227c4..f51cf614bd 100644
--- a/source/dnode/mnode/impl/src/mndProfile.c
+++ b/source/dnode/mnode/impl/src/mndProfile.c
@@ -25,6 +25,7 @@
 #include "mndUser.h"
 #include "tglobal.h"
 #include "tversion.h"
+#include "tudf.h"
 
 typedef struct {
   uint32_t id;
@@ -232,7 +233,6 @@ static int32_t mndProcessConnectReq(SRpcMsg *pReq) {
   }
 
   code = -1;
-
   taosIp2String(pReq->info.conn.clientIp, ip);
   if (mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_CONNECT) != 0) {
     mGError("user:%s, failed to login from %s since %s", pReq->info.conn.user, ip, terrstr());
@@ -245,6 +245,13 @@ static int32_t mndProcessConnectReq(SRpcMsg *pReq) {
     goto _OVER;
   }
 
+  int32_t udfdPid = -1;
+  udfGetUdfdPid(&udfdPid);
+  // if connection is from udfd, no user/password/db check
+  if (udfdPid == connReq.pid) {
+    goto _CONNECT;
+  }
+  
   if (strncmp(connReq.passwd, pUser->pass, TSDB_PASSWORD_LEN - 1) != 0) {
     mGError("user:%s, failed to login from %s since invalid pass, input:%s", pReq->info.conn.user, ip, connReq.passwd);
     code = TSDB_CODE_MND_AUTH_FAILURE;
@@ -270,6 +277,7 @@ static int32_t mndProcessConnectReq(SRpcMsg *pReq) {
     }
   }
 
+_CONNECT:
   pConn = mndCreateConn(pMnode, pReq->info.conn.user, connReq.connType, pReq->info.conn.clientIp,
                         pReq->info.conn.clientPort, connReq.pid, connReq.app, connReq.startTime);
   if (pConn == NULL) {
diff --git a/source/libs/function/src/tudf.c b/source/libs/function/src/tudf.c
index 31a7dfdbc5..5b9f44c812 100644
--- a/source/libs/function/src/tudf.c
+++ b/source/libs/function/src/tudf.c
@@ -255,6 +255,18 @@ int32_t udfStopUdfd() {
   return 0;
 }
 
+int32_t udfGetUdfdPid(int32_t* pUdfdPid) {
+  SUdfdData *pData = &udfdGlobal;
+  if (pData->spawnErr) {
+    return pData->spawnErr;
+  }
+  uv_pid_t pid = uv_process_get_pid(&pData->process);
+  if (pUdfdPid) {
+    *pUdfdPid = (int32_t)pid;
+  }
+  return TSDB_CODE_SUCCESS;
+}
+
 //==============================================================================================
 /* Copyright (c) 2013, Ben Noordhuis <info@bnoordhuis.nl>
  * The QUEUE is copied from queue.h under libuv
-- 
GitLab