From fb057bdcb2be0281b538453cf8093d147131cc8c Mon Sep 17 00:00:00 2001
From: Shuduo Sang <sangshuduo@gmail.com>
Date: Sun, 12 Mar 2023 01:19:37 +0800
Subject: [PATCH] fix: use after free for 2.6 (#20423)

* fix: taosbenchmark coverity scan issues

* test: fix default_json py logic

* fix: update taos-tools 217a267 for 2.6

* fix: use after free
---
 src/client/src/tscAsync.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/client/src/tscAsync.c b/src/client/src/tscAsync.c
index c8ef467da4..da99b3651f 100644
--- a/src/client/src/tscAsync.c
+++ b/src/client/src/tscAsync.c
@@ -259,13 +259,14 @@ static inline char *insertTags(char *sql, char *tags) {
 
     // nest call
     part2 = insertTags(sub_sql, tags);
-    free(sub_sql);
     if (part2 == NULL) {
       // unknown format, can not insert tags
       tscError("TAGS insertTags sub select sql failed. subsql=%s sql=%s", sub_sql, sql);
+      free(sub_sql);
       free(buf);
       return NULL;
     }
+    free(sub_sql);
 
     // new string is part1 + part2 + part 3
     strncpy(buf, p, part1_end - p + 1);
-- 
GitLab