From c2801a46c8c1fe92f4926135a86a250827f9a8ff Mon Sep 17 00:00:00 2001
From: Minglei Jin <mljin@taosdata.com>
Date: Fri, 18 Dec 2020 15:05:13 +0800
Subject: [PATCH] [TD-2484]<fix>: use IPv4's AI_INET instead of AI_UNSPEC

---
 src/dnode/src/dnodeTelemetry.c | 4 ++--
 src/rpc/src/rpcMain.c          | 2 +-
 src/sync/src/syncMain.c        | 2 +-
 src/util/inc/tsocket.h         | 2 +-
 src/util/src/tnettest.c        | 2 +-
 src/util/src/tsocket.c         | 4 ++--
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/dnode/src/dnodeTelemetry.c b/src/dnode/src/dnodeTelemetry.c
index 85f0137d89..ff9598ecc5 100644
--- a/src/dnode/src/dnodeTelemetry.c
+++ b/src/dnode/src/dnodeTelemetry.c
@@ -195,7 +195,7 @@ static void addRuntimeInfo(SBufferWriter* bw) {
 
 static void sendTelemetryReport() {
   char buf[128];
-  uint32_t ip = taosGetIpFromFqdn(TELEMETRY_SERVER);
+  uint32_t ip = taosGetIpv4FromFqdn(TELEMETRY_SERVER);
   if (ip == 0xffffffff) {
     dTrace("failed to get IP address of " TELEMETRY_SERVER ", reason:%s", strerror(errno));
     return;
@@ -308,4 +308,4 @@ void dnodeCleanupTelemetry() {
     pthread_join(tsTelemetryThread, NULL);
     tsem_destroy(&tsExitSem);
   }
-}
\ No newline at end of file
+}
diff --git a/src/rpc/src/rpcMain.c b/src/rpc/src/rpcMain.c
index 200d189d45..9a3a42ed15 100644
--- a/src/rpc/src/rpcMain.c
+++ b/src/rpc/src/rpcMain.c
@@ -576,7 +576,7 @@ static void rpcFreeMsg(void *msg) {
 static SRpcConn *rpcOpenConn(SRpcInfo *pRpc, char *peerFqdn, uint16_t peerPort, int8_t connType) {
   SRpcConn *pConn;
 
-  uint32_t peerIp = taosGetIpFromFqdn(peerFqdn);
+  uint32_t peerIp = taosGetIpv4FromFqdn(peerFqdn);
   if (peerIp == 0xFFFFFFFF) {
     tError("%s, failed to resolve FQDN:%s", pRpc->label, peerFqdn); 
     terrno = TSDB_CODE_RPC_FQDN_ERROR; 
diff --git a/src/sync/src/syncMain.c b/src/sync/src/syncMain.c
index ac79b48606..3369d052d8 100644
--- a/src/sync/src/syncMain.c
+++ b/src/sync/src/syncMain.c
@@ -486,7 +486,7 @@ static void syncRemovePeer(SSyncPeer *pPeer) {
 }
 
 static SSyncPeer *syncAddPeer(SSyncNode *pNode, const SNodeInfo *pInfo) {
-  uint32_t ip = taosGetIpFromFqdn(pInfo->nodeFqdn);
+  uint32_t ip = taosGetIpv4FromFqdn(pInfo->nodeFqdn);
   if (ip == 0xFFFFFFFF) {
     sError("failed to add peer, can resolve fqdn:%s since %s", pInfo->nodeFqdn, strerror(errno));
     terrno = TSDB_CODE_RPC_FQDN_ERROR;
diff --git a/src/util/inc/tsocket.h b/src/util/inc/tsocket.h
index 391cc44acc..a339955cc0 100644
--- a/src/util/inc/tsocket.h
+++ b/src/util/inc/tsocket.h
@@ -33,7 +33,7 @@ SOCKET  taosOpenTcpServerSocket(uint32_t ip, uint16_t port);
 int32_t taosKeepTcpAlive(SOCKET sockFd);
 
 int32_t  taosGetFqdn(char *);
-uint32_t taosGetIpFromFqdn(const char *);
+uint32_t taosGetIpv4FromFqdn(const char *);
 void     tinet_ntoa(char *ipstr, uint32_t ip);
 uint32_t ip2uint(const char *const ip_addr);
 
diff --git a/src/util/src/tnettest.c b/src/util/src/tnettest.c
index 89601147a5..e1b834b949 100644
--- a/src/util/src/tnettest.c
+++ b/src/util/src/tnettest.c
@@ -449,7 +449,7 @@ static void taosNetTestClient(char *host, int32_t startPort, int32_t pkgLen) {
   int32_t endPort = startPort + 11;
   uInfo("work as client, host:%s startPort:%d endPort:%d pkgLen:%d\n", host, startPort, endPort, pkgLen);
 
-  uint32_t serverIp = taosGetIpFromFqdn(host);
+  uint32_t serverIp = taosGetIpv4FromFqdn(host);
   if (serverIp == 0xFFFFFFFF) {
     uError("failed to resolve fqdn:%s", host);
     exit(-1);
diff --git a/src/util/src/tsocket.c b/src/util/src/tsocket.c
index 2543c81708..46068e8992 100644
--- a/src/util/src/tsocket.c
+++ b/src/util/src/tsocket.c
@@ -40,9 +40,9 @@ int32_t taosGetFqdn(char *fqdn) {
   return 0;
 }
 
-uint32_t taosGetIpFromFqdn(const char *fqdn) {
+uint32_t taosGetIpv4FromFqdn(const char *fqdn) {
   struct addrinfo hints = {0};
-  hints.ai_family = AF_UNSPEC;
+  hints.ai_family = AF_INET;
   hints.ai_socktype = SOCK_STREAM;
 
   struct addrinfo *result = NULL;
-- 
GitLab