From b6542fb286a6cb153c50809ea12bef893f28585c Mon Sep 17 00:00:00 2001
From: shenglian zhou <shenglian_zhou@163.com>
Date: Tue, 28 Mar 2023 08:43:34 +0800
Subject: [PATCH] fix: add language and definition body to ins_functions

---
 source/common/src/systable.c          |  2 ++
 source/dnode/mnode/impl/src/mndFunc.c | 21 +++++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/source/common/src/systable.c b/source/common/src/systable.c
index 919a09962b..06fe7482e2 100644
--- a/source/common/src/systable.c
+++ b/source/common/src/systable.c
@@ -114,6 +114,8 @@ static const SSysDbTableSchema userFuncSchema[] = {
     {.name = "create_time", .bytes = 8, .type = TSDB_DATA_TYPE_TIMESTAMP, .sysInfo = false},
     {.name = "code_len", .bytes = 4, .type = TSDB_DATA_TYPE_INT, .sysInfo = false},
     {.name = "bufsize", .bytes = 4, .type = TSDB_DATA_TYPE_INT, .sysInfo = false},
+    {.name = "language", .bytes = TSDB_TYPE_STR_MAX_LEN - 1 + VARSTR_HEADER_SIZE, .type = TSDB_DATA_TYPE_VARCHAR, .sysInfo = false},
+    {.name = "body", .bytes = TSDB_MAX_BINARY_LEN, .type = TSDB_DATA_TYPE_VARCHAR, .sysInfo = false},
 };
 
 static const SSysDbTableSchema userIdxSchema[] = {
diff --git a/source/dnode/mnode/impl/src/mndFunc.c b/source/dnode/mnode/impl/src/mndFunc.c
index 8d006f1029..7a475c61b6 100644
--- a/source/dnode/mnode/impl/src/mndFunc.c
+++ b/source/dnode/mnode/impl/src/mndFunc.c
@@ -519,6 +519,7 @@ static int32_t mndRetrieveFuncs(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBl
 
       pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
       colDataSetVal(pColInfo, numOfRows, (const char *)b2, false);
+      taosMemoryFree(b2);
     } else {
       pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
       colDataSetVal(pColInfo, numOfRows, NULL, true);
@@ -545,6 +546,26 @@ static int32_t mndRetrieveFuncs(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBl
     pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
     colDataSetVal(pColInfo, numOfRows, (const char *)&pFunc->bufSize, false);
 
+    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
+    char* language = "";
+    if (pFunc->scriptType == TSDB_FUNC_SCRIPT_BIN_LIB) {
+      language = "C";
+    } else if (pFunc->scriptType == TSDB_FUNC_SCRIPT_PYTHON) {
+      language = "Python";
+    }
+    char varLang[TSDB_TYPE_STR_MAX_LEN + 1] = {0};
+    varDataSetLen(varLang, strlen(language));
+    strcpy(varDataVal(varLang), language);
+    colDataSetVal(pColInfo, numOfRows, (const char *)varLang, false);
+
+    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
+    int32_t varCodeLen = (pFunc->codeSize + VARSTR_HEADER_SIZE) > TSDB_MAX_BINARY_LEN ? TSDB_MAX_BINARY_LEN : pFunc->codeSize + VARSTR_HEADER_SIZE;
+    char *b4 = taosMemoryMalloc(varCodeLen);
+    memcpy(varDataVal(b4), pFunc->pCode, varCodeLen - VARSTR_HEADER_SIZE);
+    varDataSetLen(b4, varCodeLen - VARSTR_HEADER_SIZE);
+    colDataSetVal(pColInfo, numOfRows, (const char*)b4, false);
+    taosMemoryFree(b4);
+
     numOfRows++;
     sdbRelease(pSdb, pFunc);
   }
-- 
GitLab