From b0ab4be6f444457e3972e4de79583c5dfc5365c3 Mon Sep 17 00:00:00 2001
From: slzhou <shenglian_zhou@163.com>
Date: Thu, 9 Mar 2023 10:32:09 +0800
Subject: [PATCH] fix: some minior improvement

---
 source/libs/function/src/udfd.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/source/libs/function/src/udfd.c b/source/libs/function/src/udfd.c
index 5f33a6552c..5f35173920 100644
--- a/source/libs/function/src/udfd.c
+++ b/source/libs/function/src/udfd.c
@@ -544,7 +544,11 @@ int32_t udfdInitUdf(char *udfName, SUdf *udf) {
 
   SScriptUdfInfo info = {0};
   convertUdf2UdfInfo(udf, &info);
-  udf->scriptPlugin->udfInitFunc(&info, &udf->scriptUdfCtx);
+  err = udf->scriptPlugin->udfInitFunc(&info, &udf->scriptUdfCtx);
+  if (err != 0) {
+    fnError("udf name %s init failed. error %d", udfName, err);
+    return err;
+  }
   return 0;
 }
 
@@ -753,7 +757,8 @@ void udfdProcessTeardownRequest(SUvUdfWork *uvUdf, SUdfRequest *request) {
   if (unloadUdf) {
     uv_cond_destroy(&udf->condReady);
     uv_mutex_destroy(&udf->lock);
-    udf->scriptPlugin->udfDestroyFunc(udf->scriptUdfCtx);
+    code = udf->scriptPlugin->udfDestroyFunc(udf->scriptUdfCtx);
+    fnDebug("udfd destroy function returns %d", code);
     taosMemoryFree(udf);
   }
   taosMemoryFree(handle);
@@ -1346,8 +1351,10 @@ int32_t udfdDeinitResidentFuncs() {
     SUdf **udfInHash = taosHashGet(global.udfsHash, funcName, strlen(funcName));
     if (udfInHash) {
       SUdf *udf = *udfInHash;
-      udf->scriptPlugin->udfDestroyFunc(udf->scriptUdfCtx);
+      int32_t code = udf->scriptPlugin->udfDestroyFunc(udf->scriptUdfCtx);
+      fnDebug("udfd destroy function returns %d", code);
       taosHashRemove(global.udfsHash, funcName, strlen(funcName));
+      taosMemoryFree(udf);
     }
   }
   taosArrayDestroy(global.residentFuncs);
-- 
GitLab