From a999e56a1dad1dd2ead3c6288cf8ec223990d984 Mon Sep 17 00:00:00 2001
From: freemine <freemine@yeah.net>
Date: Sun, 5 Feb 2023 16:08:34 +0800
Subject: [PATCH] typo: pthread_cleanup_push/pop better exist in pair

---
 source/os/src/osTimer.c       | 39 ++++++++++++++++++-----------------
 tools/shell/src/shellEngine.c | 32 ++++++++++++++--------------
 2 files changed, 37 insertions(+), 34 deletions(-)

diff --git a/source/os/src/osTimer.c b/source/os/src/osTimer.c
index d1c233ea9c..185bd9832a 100644
--- a/source/os/src/osTimer.c
+++ b/source/os/src/osTimer.c
@@ -114,27 +114,28 @@ static void         *taosProcessAlarmSignal(void *tharg) {
 
   taosThreadCleanupPush(taosDeleteTimer, &timerId);
 
-  struct itimerspec ts;
-  ts.it_value.tv_sec = 0;
-  ts.it_value.tv_nsec = 1000000 * MSECONDS_PER_TICK;
-  ts.it_interval.tv_sec = 0;
-  ts.it_interval.tv_nsec = 1000000 * MSECONDS_PER_TICK;
-
-  if (timer_settime(timerId, 0, &ts, NULL)) {
-            // printf("Failed to init timer");
-    return NULL;
-  }
-
-  int signo;
-  while (!stopTimer) {
-            if (sigwait(&sigset, &signo)) {
-              // printf("Failed to wait signal: number %d", signo);
-      continue;
+  do {
+    struct itimerspec ts;
+    ts.it_value.tv_sec = 0;
+    ts.it_value.tv_nsec = 1000000 * MSECONDS_PER_TICK;
+    ts.it_interval.tv_sec = 0;
+    ts.it_interval.tv_nsec = 1000000 * MSECONDS_PER_TICK;
+
+    if (timer_settime(timerId, 0, &ts, NULL)) {
+      // printf("Failed to init timer");
+      break;
     }
-            /* //printf("Signal handling: number %d ......\n", signo); */
 
-            callback(0);
-  }
+    int signo;
+    while (!stopTimer) {
+      if (sigwait(&sigset, &signo)) {
+        // printf("Failed to wait signal: number %d", signo);
+        continue;
+      }
+      /* //printf("Signal handling: number %d ......\n", signo); */
+      callback(0);
+    }
+  } while (0);
 
   taosThreadCleanupPop(1);
 
diff --git a/tools/shell/src/shellEngine.c b/tools/shell/src/shellEngine.c
index 479c2cf39a..d45c4fbdb5 100644
--- a/tools/shell/src/shellEngine.c
+++ b/tools/shell/src/shellEngine.c
@@ -1046,26 +1046,28 @@ void *shellThreadLoop(void *arg) {
   taosGetOldTerminalMode();
   taosThreadCleanupPush(shellCleanup, NULL);
 
-  char *command = taosMemoryMalloc(SHELL_MAX_COMMAND_SIZE);
-  if (command == NULL) {
-    printf("failed to malloc command\r\n");
-    return NULL;
-  }
-
   do {
-    memset(command, 0, SHELL_MAX_COMMAND_SIZE);
-    taosSetTerminalMode();
-
-    if (shellReadCommand(command) != 0) {
+    char *command = taosMemoryMalloc(SHELL_MAX_COMMAND_SIZE);
+    if (command == NULL) {
+      printf("failed to malloc command\r\n");
       break;
     }
 
-    taosResetTerminalMode();
-  } while (shellRunCommand(command, true) == 0);
+    do {
+      memset(command, 0, SHELL_MAX_COMMAND_SIZE);
+      taosSetTerminalMode();
+
+      if (shellReadCommand(command) != 0) {
+        break;
+      }
 
-  taosMemoryFreeClear(command);
-  shellWriteHistory();
-  shellExit();
+      taosResetTerminalMode();
+    } while (shellRunCommand(command, true) == 0);
+
+    taosMemoryFreeClear(command);
+    shellWriteHistory();
+    shellExit();
+  } while (0);
 
   taosThreadCleanupPop(1);
   return NULL;
-- 
GitLab