From 9ffdf09986e1ee511d12b97e4e39531ef63fa9df Mon Sep 17 00:00:00 2001
From: Hongze Cheng <hzcheng@taosdata.com>
Date: Fri, 25 Mar 2022 06:15:21 +0000
Subject: [PATCH] design dbc api

---
 source/libs/tdb/src/db/tdbDb.c   | 15 +++++++++++++++
 source/libs/tdb/src/inc/tdbDb.h  |  8 +++++++-
 source/libs/tdb/test/tdbTest.cpp | 25 ++++++++++++++++++++++---
 3 files changed, 44 insertions(+), 4 deletions(-)

diff --git a/source/libs/tdb/src/db/tdbDb.c b/source/libs/tdb/src/db/tdbDb.c
index e889e8772b..98f22e4d25 100644
--- a/source/libs/tdb/src/db/tdbDb.c
+++ b/source/libs/tdb/src/db/tdbDb.c
@@ -90,4 +90,19 @@ int tdbDbInsert(STDB *pDb, const void *pKey, int keyLen, const void *pVal, int v
 
 int tdbDbGet(STDB *pDb, const void *pKey, int kLen, void **ppVal, int *vLen) {
   return tdbBtreeGet(pDb->pBt, pKey, kLen, ppVal, vLen);
+}
+
+int tdbDbcOpen(STDB *pDb, STDBC **ppTDbc) {
+  // TODO
+  return 0;
+}
+
+int tdbDbNext(STDBC *pDbc, void **ppKey, int *kLen, void **ppVal, int *vLen) {
+  // TODO
+  return 0;
+}
+
+int tdbDbcClose(STDBC *pDbc) {
+  // TODO
+  return 0;
 }
\ No newline at end of file
diff --git a/source/libs/tdb/src/inc/tdbDb.h b/source/libs/tdb/src/inc/tdbDb.h
index e48de5e8c7..4e69de2bfa 100644
--- a/source/libs/tdb/src/inc/tdbDb.h
+++ b/source/libs/tdb/src/inc/tdbDb.h
@@ -21,14 +21,20 @@ extern "C" {
 #endif
 
 typedef struct STDB  STDB;
-typedef struct STDbC STDbC;
+typedef struct STDBC STDBC;
 
+// STDB
 int tdbDbOpen(const char *fname, int keyLen, int valLen, FKeyComparator keyCmprFn, STEnv *pEnv, STDB **ppDb);
 int tdbDbClose(STDB *pDb);
 int tdbDbDrop(STDB *pDb);
 int tdbDbInsert(STDB *pDb, const void *pKey, int keyLen, const void *pVal, int valLen);
 int tdbDbGet(STDB *pDb, const void *pKey, int kLen, void **ppVal, int *vLen);
 
+// STDBC
+int tdbDbcOpen(STDB *pDb, STDBC **ppTDbc);
+int tdbDbNext(STDBC *pDbc, void **ppKey, int *kLen, void **ppVal, int *vLen);
+int tdbDbcClose(STDBC *pDbc);
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/source/libs/tdb/test/tdbTest.cpp b/source/libs/tdb/test/tdbTest.cpp
index 46437392cd..164b2c0b83 100644
--- a/source/libs/tdb/test/tdbTest.cpp
+++ b/source/libs/tdb/test/tdbTest.cpp
@@ -48,9 +48,28 @@ TEST(tdb_test, simple_test) {
       TDB_FREE(pVal);
     }
 
-    {  // Loop to query the data
-       // STDbC *pDBC;
-       // tdbDBNext(pDBC, p)
+    {  // Iterate to query the DB data
+      STDBC *pDBC;
+      void  *pKey = NULL;
+      void  *pVal = NULL;
+      int    vLen, kLen;
+      int    count = 0;
+
+      ret = tdbDbcOpen(pDb, &pDBC);
+      GTEST_ASSERT_EQ(ret, 0);
+
+      for (;;) {
+        ret = tdbDbNext(pDBC, &pKey, &kLen, &pVal, &vLen);
+        if (ret < 0) break;
+        count++;
+      }
+
+      GTEST_ASSERT_EQ(count, nData);
+
+      tdbDbcClose(pDBC);
+
+      TDB_FREE(pKey);
+      TDB_FREE(pVal);
     }
   }
 
-- 
GitLab