From 806f8f5b8cd127fe60e4038a575a915a60d4cccc Mon Sep 17 00:00:00 2001 From: Bomin Zhang Date: Mon, 22 Jun 2020 14:16:46 +0800 Subject: [PATCH] fix bug: return buffer in stack update boundary testcase. --- src/client/src/tscParseInsert.c | 8 ++++---- tests/pytest/table/boundary.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/client/src/tscParseInsert.c b/src/client/src/tscParseInsert.c index 4020d201ce..6e922d566b 100644 --- a/src/client/src/tscParseInsert.c +++ b/src/client/src/tscParseInsert.c @@ -989,13 +989,11 @@ static int32_t tscCheckIfCreateTable(char **sqlstr, SSqlObj *pSql) { } int validateTableName(char *tblName, int len, SSQLToken* psTblToken) { - char buf[TSDB_TABLE_ID_LEN] = {0}; - tstrncpy(buf, tblName, sizeof(buf)); + tstrncpy(psTblToken->z, tblName, TSDB_TABLE_ID_LEN); psTblToken->n = len; psTblToken->type = TK_ID; - psTblToken->z = buf; - tSQLGetToken(buf, &psTblToken->type); + tSQLGetToken(psTblToken->z, &psTblToken->type); return tscValidateName(psTblToken); } @@ -1081,7 +1079,9 @@ int tsParseInsertSql(SSqlObj *pSql) { } pCmd->curSql = sToken.z; + char buf[TSDB_TABLE_ID_LEN]; SSQLToken sTblToken; + sTblToken.z = buf; // Check if the table name available or not if (validateTableName(sToken.z, sToken.n, &sTblToken) != TSDB_CODE_SUCCESS) { code = tscInvalidSQLErrMsg(pCmd->payload, "table name invalid", sToken.z); diff --git a/tests/pytest/table/boundary.py b/tests/pytest/table/boundary.py index 50586b72ff..a1bf096499 100644 --- a/tests/pytest/table/boundary.py +++ b/tests/pytest/table/boundary.py @@ -141,7 +141,7 @@ class TDTestCase: tdSql.prepare() # 8 bytes for timestamp - maxRowSize = 65535 - 8 + maxRowSize = self.getLimitFromSourceCode('TSDB_MAX_BYTES_PER_ROW') - 8 maxCols = self.getLimitFromSourceCode('TSDB_MAX_COLUMNS') - 1 # for binary cols, 2 bytes are used for length -- GitLab